refactor: remove redundant InitInputType class attribute#10
Merged
Conversation
Add _get_init_input_type() classmethod that infers the init input type from the generic parameter Function[T] using __orig_bases__ and get_args(). This eliminates the need for explicit InitInputType class attributes in subclasses. - Add _get_init_input_type() with per-class caching - Remove InitInputType from ScalarFunctionGenerator - Remove InitInputType from TableFunctionBase 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_get_init_input_type()classmethod to Function that infers the init input type from the generic parameterFunction[T]using__orig_bases__andget_args()InitInputTypeclass attributes from ScalarFunctionGenerator and TableFunctionBaseThis eliminates the duplication where the type is specified both in the generic parameter and as a class attribute.
Test plan
🤖 Generated with Claude Code