Skip to content

Remove arg_types parameter from extract_argument_specs()#20

Merged
rustyconover merged 2 commits into
mainfrom
feature/extract-argument-specs-refactor
Jan 5, 2026
Merged

Remove arg_types parameter from extract_argument_specs()#20
rustyconover merged 2 commits into
mainfrom
feature/extract-argument-specs-refactor

Conversation

@rustyconover

Copy link
Copy Markdown
Contributor

Summary

  • Removes the arg_types parameter from extract_argument_specs()
  • Adds automatic Arrow type inference using:
    1. Explicit arrow_type on Arg (highest priority)
    2. Python type hints via PYTHON_TO_ARROW mapping
    3. pa.null() for TableInput and AnyArrow types
    4. Warning + pa.null() default for unknown types
  • Updates existing tests to use type annotations

This depends on PR #19 (arrow_type parameter on Arg).

Test plan

  • All 656 tests pass
  • Ruff linting passes
  • mypy type checking passes

🤖 Generated with Claude Code

rustyconover and others added 2 commits January 5, 2026 15:56
Update extract_argument_specs() to automatically determine Arrow types:
1. Use explicit arrow_type on Arg if set (highest priority)
2. Infer from Python type hints using PYTHON_TO_ARROW mapping
3. Use pa.null() for TableInput and AnyArrow types
4. Warn and default to pa.null() for unknown types

This simplifies the API by removing the need to manually specify
arg_types mappings.

Also updates tests to use type annotations instead of arg_types.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Base automatically changed from feature/arg-arrow-type to main January 5, 2026 21:09
@rustyconover rustyconover merged commit 8739d47 into main Jan 5, 2026
@rustyconover rustyconover deleted the feature/extract-argument-specs-refactor branch January 5, 2026 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant