Complete ReadOnlyCatalogInterface implementation#28
Merged
Conversation
Add CatalogReadOnlyError exception and implement ReadOnlyCatalogInterface that raises this error for all DDL operations (create, drop, rename, modify). Read-only catalogs only support read operations: - catalogs() - list catalogs - catalog_attach/detach - attach to/detach from catalogs - schemas() - list schemas - schema_get() - get schema info - schema_contents() - list schema contents - table_get(), view_get() - get table/view info - table_scan_function_get() - get scan function for tables 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CatalogReadOnlyErrorexception tovgi/exceptions.pyReadOnlyCatalogInterfacewith all DDL method overrides that raiseCatalogReadOnlyErrorChanges
vgi/exceptions.py: AddedCatalogReadOnlyErrorexception classvgi/catalog/catalog_interface.py: Implemented all DDL method overrides inReadOnlyCatalogInterface:catalog_create,catalog_dropcatalog_transaction_begin,catalog_transaction_commit,catalog_transaction_rollbackschema_create,schema_droptable_create,table_drop,table_comment_set,table_renametable_column_add,table_column_drop,table_column_renametable_column_default_set,table_column_default_drop,table_column_type_changetable_not_null_drop,table_not_null_setview_create,view_drop,view_rename,view_comment_setTest plan
🤖 Generated with Claude Code