Skip to content

Add ty type checker alongside mypy #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rustyconover merged 1 commit into from
Jan 2, 2026
Merged

Add ty type checker alongside mypy #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,8 @@ jobs:
- name: Check linting
run: uv run ruff check .

- name: Type check
- name: Type check (mypy)
run: uv run mypy vgi/

- name: Type check (ty)
run: uv run ty check vgi/
4 changes: 4 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ warn_unused_ignores = true
module = "structlog.*"
ignore_missing_imports = true

[tool.ty.environment]
python-version = "3.12"

[tool.pytest.ini_options]
addopts = "--mypy --ruff"
testpaths = ["tests"]
Expand All @@ -50,4 +53,5 @@ testpaths = ["tests"]
dev = [
"lxml>=6.0.2",
"pytest-timeout>=2.4.0",
"ty>=0.0.8",
]
27 changes: 27 additions & 0 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vgi/client/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1255,7 +1255,7 @@ def start(self) -> None:
)
self._stderr_thread.start()

self._stdout_buffered = io.BufferedReader(self._proc.stdout)
self._stdout_buffered = io.BufferedReader(cast(io.RawIOBase, self._proc.stdout))
assert self._proc.stdin is not None, "stdin pipe not created for worker"
self._stdin_sink = pa.PythonFile(cast(io.IOBase, self._proc.stdin))

Expand Down