refactor: change cardinality() method to property#6
Merged
Conversation
Change cardinality from a method to a property for API consistency with output_schema. Both return immutable data, so having consistent access patterns improves the API. Changes: - vgi/table_function.py: Add @Property decorator to cardinality - vgi/examples/table.py: Add @Property to all cardinality overrides - vgi/examples/table_in_out.py: Add @Property to all cardinality overrides - tests/: Update test overrides and call sites (.cardinality instead of .cardinality()) - docs/generator-api.md: Update example to use @Property Closes: vgi-python-bku 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cardinality()method tocardinalityproperty for API consistency withoutput_schemaChanges
vgi/table_function.py: Add@propertydecorator to cardinalityvgi/examples/table.py: Add@propertyto all cardinality overridesvgi/examples/table_in_out.py: Add@propertyto all cardinality overrides.cardinalityinstead of.cardinality())docs/generator-api.md: Update example to use@propertyTest plan
Closes: vgi-python-bku
🤖 Generated with Claude Code