refactor: extract exception handling to Function base class#8
Merged
Conversation
Move _should_terminate and add _create_error_output helper to the Function base class, eliminating duplication across ScalarFunctionGenerator, TableFunctionGenerator, and TableInOutGeneratorFunction. - Add _should_terminate() to Function (was duplicated 3x) - Add _create_error_output() helper to Function - Update _process_with_exception_handling in all 3 classes to use helper - Net reduction of 9 lines of code 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_should_terminateto Function base class (was duplicated in 3 places)_create_error_outputhelper to Function base class_process_with_exception_handlingin all function types to use the new helperTest plan
🤖 Generated with Claude Code