Feat/items#62
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for consumable potions and dungeon ticket items, including their serialization, deserialization, and in-game logic for drops and usage. It introduces new item types (
ConsumableItemandTicketItem), updates item encoding/decoding, and ensures their assets are correctly imported and loaded. Additionally, it enhances monster drop logic to include potions and tickets.New item types and logic:
ConsumableItemandTicketItemclasses, encapsulating properties and behaviors for potions and dungeon tickets, including healing, burn removal, and ticket difficulty. Also added theItemCatalogutility for item creation and identification.Serialization and deserialization:
PlayerProfileSnapshot.EncodeandDecodemethods to properly handle the newConsumableItemandTicketItemtypes, ensuring correct storage and retrieval of their properties. [1] [2]LoadTextureOrNullto search for item textures in the newAssets/items/path.ReadBoolhelper method to robustly parse boolean values from dictionaries.Monster drop logic:
Monster.TrySpawnDropsto roll and spawn potion and ticket drops using the new item types and utilities. [1] [2]Asset imports:
.importfiles for all potion and ticket item sprites to ensure textures are available in the Godot project. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]