Expand api version constraint to 1.xx#5
Open
ilyanekhay-uta wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi folks!
I tried using serverless-pypi 0.0.6 yesterday and discovered it doesn't support the current PyPI as an upstream since it's now returning
api-version="1.3"instead of"1.0"as expected by the current code.I just tested expanding the constraint to "1.xx" via a regex as can be seen in this PR, and that seems to be working correctly.
While testing, I had also discovered that new versions of Pydantic and FastAPI are incompatible with serverless-pypi=0.0.6, so I added some version constraints that seem to be the least restrictive while getting the code to work:
json_dumps,json_loadsin class definitionsOptional[Response]I'd really appreciate y'all merging this and publishing a new version, and thanks a lot for this useful project!