Modernization, Remove macOS target#6
Open
pauljohanneskraft wants to merge 2 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Modernizes the project by removing the macOS app and macOS UI test targets, leaving an iOS-only Xcode project. Also adds a .gitignore (previously absent — bold move shipping an Xcode repo without one) and documents iOS-only requirements in the README.
Changes:
- Delete macOS app and
Tests macOSsources, plists, entitlements, and corresponding targets/build phases/configurations fromproject.pbxproj. - Add a fresh
.gitignorecovering Xcode user state, build output, SPM, CocoaPods, Carthage, and fastlane artifacts; drop a checked-inxcuserdataplist. - Add a "Requirements" section to the README pointing at the iOS scheme.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Recipes/Recipes.xcodeproj/project.pbxproj | Removes macOS/Tests macOS targets, build phases, dependencies, and configurations (but leaves a few orphaned file/group references behind). |
| Recipes/macOS/Info.plist | Deletes the macOS app Info.plist. |
| Recipes/macOS/macOS.entitlements | Deletes the macOS sandbox entitlements. |
| Recipes/Tests macOS/Tests_macOS.swift | Deletes the macOS UI test stub. |
| Recipes/Tests macOS/Info.plist | Deletes the macOS test bundle Info.plist. |
| Recipes/Recipes.xcodeproj/.../xcschememanagement.plist | Drops user-specific scheme ordering that should never have been committed. |
| README.md | Documents iOS 14+/Xcode 12+ requirements and the iOS scheme. |
| .gitignore | New ignore rules for Xcode, SPM, CocoaPods, Carthage, and fastlane noise. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
60
to
66
| 9BE3629B2583CD1E00807BFC /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; }; | ||
| 9BE3629C2583CD1E00807BFC /* macOS.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; path = macOS.entitlements; sourceTree = "<group>"; }; | ||
| 9BE362A12583CD1F00807BFC /* Tests iOS.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = "Tests iOS.xctest"; sourceTree = BUILT_PRODUCTS_DIR; }; | ||
| 9BE362A52583CD1F00807BFC /* Tests_iOS.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Tests_iOS.swift; sourceTree = "<group>"; }; | ||
| 9BE362A72583CD1F00807BFC /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; }; | ||
| 9BE362AC2583CD1F00807BFC /* Tests macOS.xctest */ = {isa = PBXFileReference; explicitFileType = wrapper.cfbundle; includeInIndex = 0; path = "Tests macOS.xctest"; sourceTree = BUILT_PRODUCTS_DIR; }; | ||
| 9BE362B02583CD1F00807BFC /* Tests_macOS.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = Tests_macOS.swift; sourceTree = "<group>"; }; | ||
| 9BE362B22583CD1F00807BFC /* Info.plist */ = {isa = PBXFileReference; lastKnownFileType = text.plist.xml; path = Info.plist; sourceTree = "<group>"; }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.