Normalize beta parameter string aliases before calling downstream functions#111
Merged
smasongarrison merged 4 commits intodev_mainfrom Jan 28, 2026
Merged
Normalize beta parameter string aliases before calling downstream functions#111smasongarrison merged 4 commits intodev_mainfrom
smasongarrison merged 4 commits intodev_mainfrom
Conversation
…downstream functions Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com>
…all string aliases Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com>
… alias Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update pedigree simulation code normalization improvements
Normalize beta parameter string aliases before calling downstream functions
Jan 28, 2026
smasongarrison
approved these changes
Jan 28, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev_main #111 +/- ##
============================================
+ Coverage 84.31% 84.37% +0.06%
============================================
Files 27 27
Lines 4228 4238 +10
============================================
+ Hits 3565 3576 +11
+ Misses 663 662 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
smasongarrison
added a commit
that referenced
this pull request
Jan 28, 2026
…ctions (#111) * Initial plan * Normalize beta parameter string aliases to TRUE/FALSE before calling downstream functions Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com> * Fix inconsistencies in beta parameter validation and add support for all string aliases Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com> * Fix test for original alias to use proper seed and add test for index alias Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildWithinGenerations()andbuildBetweenGenerations()acceptbeta = "optimized"/"indexed"but pass these strings to helpers that useif (beta)checks, causing errors.Changes
Parameter normalization: Added validation logic in both entry-point functions to convert string aliases to logical values before calling helpers:
"optimized"→TRUE"base","original"→FALSE"index","indexed"→ throw "not yet implemented" errorConsistency fixes: Made both functions check for unimplemented aliases first, support the same set of string values, and use identical error messages
Test coverage: Added tests verifying string aliases produce identical results to their boolean equivalents
Example
Downstream functions (
createGenDataFrame,determineSex,assignCoupleIDs,adjustKidsPerCouple,markPotentialChildren) now always receiveTRUEorFALSE, never strings.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.