Add support for non-numeric (categorical) predictors in discord_data()#35
Draft
Add support for non-numeric (categorical) predictors in discord_data()#35
Conversation
Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com>
Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com>
Co-authored-by: smasongarrison <6001608+smasongarrison@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update make_mean_diffs to handle non-numeric predictors
Add support for non-numeric (categorical) predictors in discord_data()
Oct 17, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
==========================================
- Coverage 91.20% 91.09% -0.11%
==========================================
Files 7 7
Lines 853 865 +12
==========================================
+ Hits 778 788 +10
- Misses 75 77 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3037ee0 to
132fec5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds support for non-numeric (categorical) predictors in the
discord_data()andmake_mean_diffs()functions, resolving the issue where predicting outcomes based on categorical variables like location ("south" or "north") would fail.Problem
Previously, the
make_mean_diffs()function attempted to compute differences and means for all variables, including categorical ones. This caused errors or warnings when non-numeric predictors were used, as operations like subtraction and mean calculation are not meaningful for categorical data.Solution
Modified both implementations of
make_mean_diffs()to:is.numeric()before processing_1and_2columns, set_diffand_meantoNAExample Usage
Changes Made
Core Functions
make_mean_diffs_ram_optimized(): Added type checking and conditional processingmake_mean_diffs_fast(): Added same logic for vectorized operationssuppressMessages()andsuppressWarnings()since type handling is now explicitDocumentation
discord_data()parameter documentation with categorical predictor examplesTests
test-categorical_predictors.R) covering:Use Cases
This enhancement enables researchers to:
Backward Compatibility
✅ All changes are backward compatible:
Fixes issue about creating discordant kinship data with non-numeric predictors.
Original prompt
Fixes #5
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.