Open
Conversation
NTx86
reviewed
Jan 3, 2026
Collaborator
NTx86
left a comment
NTx86
left a comment
There was a problem hiding this comment.
Did you define properties of Decal in reflection?
Contributor
Author
Do you mean the texture, specular, and shiny props? If so, yes |
Collaborator
|
I thought that they're usually defined in cpp files and have parameters? I do not know exact details myself since I haven't tried decompiling anything from v8datamodel yet so please correct me if I'm wrong. |
Contributor
Author
I'll look into it |
Contributor
Author
|
cpp declerations done |
NTx86
reviewed
Jan 3, 2026
NTx86
approved these changes
Jan 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FaceInstance mostly matches besides constructor and Decal mostly matches besides Deconstructor.
also note that boost git ignore stuff was moved as the solution currently requires it to compile