Refactor entry switch into strategy pattern#21
Open
Justin-dr wants to merge 1 commit into
Open
Conversation
Author
|
The Enum path also doesn't cleanly fit into a strategy so I just left that in the ConfigMenu class. That being said I did extract it to its own method for clarity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains only a refactor of the giant entry switch to more manageable ConfigStrategies.
Further refactoring is possible (there is a lot of duplicate code), but is out of scope for this PR.
Changes tested locally but feel free to validate them yourself as well.