Skip to content

fix for windows#6

Merged
ajz34 merged 2 commits into
RESTGroup:mainfrom
jeanwsr:for-win
Jun 17, 2026
Merged

fix for windows#6
ajz34 merged 2 commits into
RESTGroup:mainfrom
jeanwsr:for-win

Conversation

@jeanwsr

@jeanwsr jeanwsr commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Fix Windows support for dynamic library loading.

  • PATH separator: : on Unix/macOS, ; on Windows.
  • CONDA_PREFIX Windows library paths: on Windows, also searches {CONDA_PREFIX}/Library/bin and {CONDA_PREFIX}/Library/lib (in addition to the existing {CONDA_PREFIX}/lib).
  • LIB_NAME_LINK SO version: "s-dftd3-1" on Windows to match the conda MinGW shared library libs-dftd3-1.dll. The -1 SO version may need updating if upstream bumps ABI.
  • DLL_PREFIX: hardcoded "lib" on Windows since std::env::consts::DLL_PREFIX returns "" for all Windows targets regardless of toolchain, but MinGW convention uses the lib prefix.

Fully written by DeepSeek V4 Pro based on fully human analysis of the problem.

@jeanwsr jeanwsr marked this pull request as draft June 13, 2026 09:29
@jeanwsr

jeanwsr commented Jun 13, 2026

Copy link
Copy Markdown
Contributor Author

The fix is based on what i see after failure on windows, but I don't have an instant way to test it since all windows build is not local. Maybe we could just blind check and publish a crate for test.

@jeanwsr jeanwsr marked this pull request as ready for review June 13, 2026 09:40
@ajz34 ajz34 merged commit ca42beb into RESTGroup:main Jun 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants