Add Linux support#3
Merged
Merged
Conversation
Guard String(localized:) behind a Linux shim that resolves keys to themselves (the API doesn't exist on swift-corelibs-foundation), replace the `\(x, format: .number)` interpolation sugar with `.formatted(.number)` in CIFPError.swift, and import FoundationNetworking where URLSession is used. Port the E2E tool's progress bar off NSKeyValueObservation (Darwin only) to polling, which lets it build and run on Linux too. Add Ubuntu to the CI matrix. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Keep the Build-and-Test matrix on both macOS and Ubuntu. Move the SwiftLint job to ubuntu-latest via the ghcr.io/realm/swiftlint container (SwiftLint runs cleanly on Linux), and move the documentation build to ubuntu-latest. Periphery stays on macOS (needs an index-store build with no clean Linux install path). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
String(localized:)on Linux (unavailable in swift-corelibs-foundation), replace\(x, format: .number)interpolation with.formatted(.number), and importFoundationNetworkingwhereURLSession/HTTPURLResponseare used.NSKeyValueObservation(Darwin-only) to a polling-based implementation, enablingSwiftCIFP_E2Eto build and run on Linux.ubuntu-latest/ Swift 6.3 to the CI test matrix (replacing the standalonetest-linuxjob).Test plan
swift build/swift testgreen on macOSswift build/swift testgreen on Linux (Dockerswift:6.3)SwiftCIFP_E2Eruns on Linux against real FAA CIFP data (177,812 records, 0 errors)swiftlint --strictandswift format lint --strictpassactionlinton the CI workflow change🤖 Generated with Claude Code