Skip to content

Fix: Resolved outfit saving/loading issues for legacy & migrated databases (#4) #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CheloLima wants to merge 3 commits into
base: main
Choose a base branch
from
+47 −28
Open

Fix: Resolved outfit saving/loading issues for legacy & migrated databases (#4) #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f36f8a
Update playeroutfits.lua
CheloLima May 9, 2026
0432eb0
Update playeroutfits.lua
CheloLima May 9, 2026
e3e144c
Update server.lua
CheloLima May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 31 additions & 6 deletions server/database/playeroutfits.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,13 @@ function Database.PlayerOutfits.GetByOutfit(name, citizenid) -- for validate dup
end

function Database.PlayerOutfits.Add(citizenID, outfitName, model, components, props)
return MySQL.insert.await("INSERT INTO player_outfits (citizenid, outfitname, model, components, props) VALUES (?, ?, ?, ?, ?)", {
citizenID,
outfitName,
model,
components,
props
local skinData = json.encode({components = components, props = props})
return MySQL.insert.await("INSERT INTO player_outfits (citizenid, outfitname, model, components, props, skin) VALUES (?, ?, ?, ?, ?, ?)", {
citizenID, outfitName, model, components, props, skinData
})
end


function Database.PlayerOutfits.Update(outfitID, model, components, props)
return MySQL.update.await("UPDATE player_outfits SET model = ?, components = ?, props = ? WHERE id = ?", {
model,
Expand All @@ -34,3 +32,30 @@ end
function Database.PlayerOutfits.DeleteByID(id)
MySQL.query.await("DELETE FROM player_outfits WHERE id = ?", {id})
end


Citizen.CreateThread(function()
local result = MySQL.query.await("DESCRIBE player_outfits")
if result then
local hasComponents, hasProps, outfitIdColumn = false, false, nil

for i=1, #result do
if result[i].Field == "components" then hasComponents = true end
if result[i].Field == "props" then hasProps = true end
if result[i].Field == "outfitId" then outfitIdColumn = result[i] end
end

-- Fehlende Spalten hinzufügen
if not hasComponents then
MySQL.query.await("ALTER TABLE player_outfits ADD COLUMN components LONGTEXT DEFAULT NULL")
end
if not hasProps then
MySQL.query.await("ALTER TABLE player_outfits ADD COLUMN props LONGTEXT DEFAULT NULL")
end

-- outfitId reparieren (auf Nullable setzen)
if outfitIdColumn and outfitIdColumn.Null == "NO" then
MySQL.query.await("ALTER TABLE player_outfits MODIFY COLUMN outfitId varchar(50) DEFAULT NULL")
end
end
end)
38 changes: 16 additions & 22 deletions server/server.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,30 @@ local function getMoneyForShop(shopType)
elseif shopType == "surgeon" then
money = Config.SurgeonCost
end

return money
end

local function getOutfitsForPlayer(citizenid)
outfitCache[citizenid] = {}
local result = Database.PlayerOutfits.GetAllByCitizenID(citizenid)
for i = 1, #result, 1 do
local components = result[i].components and json.decode(result[i].components)
local props = result[i].props and json.decode(result[i].props)

if (not components or not props) and result[i].skin then
local legacyData = json.decode(result[i].skin)
if legacyData then
components = components or legacyData.components
props = props or legacyData.props
end
end

outfitCache[citizenid][#outfitCache[citizenid] + 1] = {
id = result[i].id,
name = result[i].outfitname,
model = result[i].model,
components = json.decode(result[i].components),
props = json.decode(result[i].props)
components = components or {},
props = props or {}
}
end
end
Expand All @@ -39,15 +49,12 @@ local function GenerateUniqueCode()
return code
end

-- Callback(s)

lib.callback.register("illenium-appearance:server:generateOutfitCode", function(_, outfitID)
local existingOutfitCode = Database.PlayerOutfitCodes.GetByOutfitID(outfitID)
if not existingOutfitCode then
local code = GenerateUniqueCode()
local id = Database.PlayerOutfitCodes.Add(outfitID, code)
if not id then
print("Something went wrong while generating outfit code")
return
end
return code
Expand All @@ -61,30 +68,23 @@ lib.callback.register("illenium-appearance:server:importOutfitCode", function(so
if not existingOutfitCode then
return nil
end

local playerOutfit = Database.PlayerOutfits.GetByID(existingOutfitCode.outfitid)
if not playerOutfit then
return
end

if playerOutfit.citizenid == citizenID then return end -- Validation when someone tried to duplicate own outfit
if Database.PlayerOutfits.GetByOutfit(outfitName, citizenID) then return end -- Validation duplicate outfit name, if validate on local id, someone can "spam error" server-sided

if playerOutfit.citizenid == citizenID then return end
if Database.PlayerOutfits.GetByOutfit(outfitName, citizenID) then return end
local id = Database.PlayerOutfits.Add(citizenID, outfitName, playerOutfit.model, playerOutfit.components, playerOutfit.props)

if not id then
print("Something went wrong while importing the outfit")
return
end

outfitCache[citizenID][#outfitCache[citizenID] + 1] = {
id = id,
name = outfitName,
model = playerOutfit.model,
components = json.decode(playerOutfit.components),
props = json.decode(playerOutfit.props)
}

return true
end)

Expand All @@ -105,7 +105,6 @@ end)
lib.callback.register("illenium-appearance:server:payForTattoo", function(source, tattoo)
local src = source
local cost = tattoo.cost or Config.TattooCost

if Framework.RemoveMoney(src, "cash", cost) then
lib.notify(src, {
title = _L("purchase.tattoo.success.title"),
Expand Down Expand Up @@ -138,11 +137,9 @@ lib.callback.register("illenium-appearance:server:getManagementOutfits", functio
if mType == "Gang" then
job = Framework.GetGang(source)
end

local grade = tonumber(job.grade.level)
local managementOutfits = {}
local result = Database.ManagementOutfits.GetAllByJob(mType, job.name, gender)

for i = 1, #result, 1 do
if grade >= result[i].minrank then
managementOutfits[#managementOutfits + 1] = {
Expand Down Expand Up @@ -251,10 +248,9 @@ RegisterNetEvent("illenium-appearance:server:saveManagementOutfit", function(out
if not id then
return
end

lib.notify(src, {
title = _L("outfits.save.success.title"),
description = string.format(_L("outfits.save.success.description"), outfitData.Name),
description = string.format(_L("outfits.save.success.description"), outfitData.Name),
type = "success",
position = Config.NotifyOptions.position
})
Expand All @@ -274,7 +270,6 @@ RegisterNetEvent("illenium-appearance:server:deleteOutfit", function(id)
local citizenID = Framework.GetPlayerID(src)
Database.PlayerOutfitCodes.DeleteByOutfitID(id)
Database.PlayerOutfits.DeleteByID(id)

for k, v in ipairs(outfitCache[citizenID]) do
if v.id == id then
table.remove(outfitCache[citizenID], k)
Expand Down Expand Up @@ -337,7 +332,6 @@ if Config.EnableJobOutfitsCommand then
lib.addCommand("joboutfits", { help = _L("commands.joboutfits.title"), }, function(source)
TriggerClientEvent("illenium-apearance:client:outfitsCommand", source, true)
end)

lib.addCommand("gangoutfits", { help = _L("commands.gangoutfits.title"), }, function(source)
TriggerClientEvent("illenium-apearance:client:outfitsCommand", source)
end)
Expand Down