Skip to content

ppsspp-sa: bump to v1.20.1#2390

Open
edemirkan wants to merge 9 commits intoROCKNIX:nextfrom
edemirkan:feat-package-bump
Open

ppsspp-sa: bump to v1.20.1#2390
edemirkan wants to merge 9 commits intoROCKNIX:nextfrom
edemirkan:feat-package-bump

Conversation

@edemirkan
Copy link
Contributor

PR Details

  • ppsspp updated to v1.20.1, patch set recreated for the new codebase.
  • cheat.db updated to 17/01/2026
  • syncthing updated to 2.0.15

Tested OK on my RK3566 - RGB30

Build artifacts for RK3566 and S922X
https://github.com/edemirkan/rocknix-distribution/actions/runs/22780256117

PPSSPP v1.20 Changelog
https://www.ppsspp.org/blog/1-20-release-announcement/

Note for PPSSPP: Looks like there were some new additions to assets folder, mainly new fonts and a new ui_images folder. Not sure how to handle that within the incremental update. In my case I just deleted /storage/.config/ppsspp/assets/ and let start_ppsspp.sh recreate it.

@RetroGFX
Copy link

RetroGFX commented Mar 8, 2026

I'm in the process of bumping this for uOS also, and came across some things i wanted to point out. The patch for paths, the save states code was refactored and it's alot more complicated now it looks like to patch in the game name over the disk id like before. I thought about taking this approach and leaving it out, but the issue with that is it will break all existing save states. They won't even show up in the gui. The only way around this is for users to make a new state, get the disk id, then rename the old state. I'm going to keep trying to figure out how to patch it in because it makes identifying what states are what a nightmare.
Also, the assets thing can be handled with the post update script, take a look at that. Might be the right approach to handle the update of the assets folder. Good work

@RetroGFX
Copy link

RetroGFX commented Mar 8, 2026

index a8300543d..37c12caa4 100644
--- a/Core/SaveState.cpp
+++ b/Core/SaveState.cpp
@@ -333,7 +333,7 @@ int g_screenshotFailures;
 	}
 
 	std::string GetGamePrefix(const ParamSFOData &paramSFO) {
-		return GenerateFullDiscId(paramSFO);
+		return PSP_CoreParameter().fileToStart.WithReplacedExtension("").GetFilename();
 	}
 
 	// The prefix is always based on GenerateFullDiscId. So we can find these by scanning, too.
 	

@RetroGFX
Copy link

RetroGFX commented Mar 8, 2026

this worked for me with old saves, and generating new savestates with the rom name instead of diskid

@edemirkan edemirkan marked this pull request as draft March 8, 2026 19:29
@edemirkan
Copy link
Contributor Author

Thanks for the feedback. I'll have a look into post_update hook and the savestate patch you sent.

While on this, do you know what's this do not mute patch is about? Why would there be a second instance of ppsspp?

https://github.com/ROCKNIX/distribution/pull/2390/changes#diff-a800a4e54dc858e0176b82c7cd7c2ca8e48e74e65bb6668fc827a07929fa0433R9

start_ppsspp.sh should effectively be killing any instance w/ set_kill set "-9 ppsspp" anyways.

@RetroGFX
Copy link

RetroGFX commented Mar 8, 2026

Thanks for the feedback. I'll have a look into post_update hook and the savestate patch you sent.

While on this, do you know what's this do not mute patch is about? Why would there be a second instance of ppsspp?

https://github.com/ROCKNIX/distribution/pull/2390/changes#diff-a800a4e54dc858e0176b82c7cd7c2ca8e48e74e65bb6668fc827a07929fa0433R9

start_ppsspp.sh should effectively be killing any instance w/ set_kill set "-9 ppsspp" anyways.

So basically the do not mute patch stops ppsspp from setting the app volume to 0, which can happen during a force close or crash.. if this happens the internal volume would be reset to 0, and the user will start ppsspp again and there will be no sound. This patch stops that from happening

@edemirkan edemirkan force-pushed the feat-package-bump branch 2 times, most recently from fd6c9a8 to eeecda9 Compare March 8, 2026 21:33
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop this and create a different PR for syncthing

cd -
fi


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary extra line


std::string GetGamePrefix(const ParamSFOData &paramSFO) {
- return GenerateFullDiscId(paramSFO);
+ return PSP_CoreParameter().fileToStart.WithReplacedExtension("").GetFilename();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems related to patch 004-set-paths.patch
I'd merge them then

@edemirkan edemirkan changed the title chore: ppsspp & syncthing version bump chore: ppsspp-sa update to v1.20.1 Mar 8, 2026
@edemirkan edemirkan force-pushed the feat-package-bump branch from a87226b to 4972876 Compare March 8, 2026 23:34
@edemirkan edemirkan changed the title chore: ppsspp-sa update to v1.20.1 ppsspp-sa: bump to v1.20.1 Mar 8, 2026
@edemirkan edemirkan marked this pull request as ready for review March 9, 2026 03:21
@edemirkan edemirkan requested a review from loki666 March 9, 2026 03:21
@edemirkan
Copy link
Contributor Author

Latest build artifacts for RK3566 & S922X

https://github.com/edemirkan/rocknix-distribution/actions/runs/22832460409

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants