Conversation
|
I'm in the process of bumping this for uOS also, and came across some things i wanted to point out. The patch for paths, the save states code was refactored and it's alot more complicated now it looks like to patch in the game name over the disk id like before. I thought about taking this approach and leaving it out, but the issue with that is it will break all existing save states. They won't even show up in the gui. The only way around this is for users to make a new state, get the disk id, then rename the old state. I'm going to keep trying to figure out how to patch it in because it makes identifying what states are what a nightmare. |
index a8300543d..37c12caa4 100644
--- a/Core/SaveState.cpp
+++ b/Core/SaveState.cpp
@@ -333,7 +333,7 @@ int g_screenshotFailures;
}
std::string GetGamePrefix(const ParamSFOData ¶mSFO) {
- return GenerateFullDiscId(paramSFO);
+ return PSP_CoreParameter().fileToStart.WithReplacedExtension("").GetFilename();
}
// The prefix is always based on GenerateFullDiscId. So we can find these by scanning, too.
|
|
this worked for me with old saves, and generating new savestates with the rom name instead of diskid |
|
Thanks for the feedback. I'll have a look into While on this, do you know what's this do not mute patch is about? Why would there be a second instance of ppsspp?
|
So basically the do not mute patch stops ppsspp from setting the app volume to 0, which can happen during a force close or crash.. if this happens the internal volume would be reset to 0, and the user will start ppsspp again and there will be no sound. This patch stops that from happening |
fd6c9a8 to
eeecda9
Compare
There was a problem hiding this comment.
drop this and create a different PR for syncthing
| cd - | ||
| fi | ||
|
|
||
|
|
|
|
||
| std::string GetGamePrefix(const ParamSFOData ¶mSFO) { | ||
| - return GenerateFullDiscId(paramSFO); | ||
| + return PSP_CoreParameter().fileToStart.WithReplacedExtension("").GetFilename(); |
There was a problem hiding this comment.
this seems related to patch 004-set-paths.patch
I'd merge them then
a87226b to
4972876
Compare
|
Latest build artifacts for RK3566 & S922X https://github.com/edemirkan/rocknix-distribution/actions/runs/22832460409 |
PR Details
Tested OK on my RK3566 - RGB30
Build artifacts for RK3566 and S922X
https://github.com/edemirkan/rocknix-distribution/actions/runs/22780256117
PPSSPP v1.20 Changelog
https://www.ppsspp.org/blog/1-20-release-announcement/
Note for PPSSPP: Looks like there were some new additions to assets folder, mainly new fonts and a new
ui_imagesfolder. Not sure how to handle that within the incremental update. In my case I just deleted/storage/.config/ppsspp/assets/and let start_ppsspp.sh recreate it.