Skip to content

[atom-vllm] Attention CP for DSA models#1618

Draft
whx-sjtu wants to merge 7 commits into
mainfrom
hexwang/vllm_dsa_cp
Draft

[atom-vllm] Attention CP for DSA models#1618
whx-sjtu wants to merge 7 commits into
mainfrom
hexwang/vllm_dsa_cp

Conversation

@whx-sjtu

@whx-sjtu whx-sjtu commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Motivation

Advanced version of #196.

Technical Details

  • For Attention part, weights are stored normally in TP. When running prefill or mixed batch, gather attention weights layer by layer to obtain full weights, and then perform full CP for attention as described in [RFC]: Parallel strategy for Deepseek v3.2 like models #196.
  • For MoE part, stay full TP. When running prefill or mixed batch, replace the all-reduces before and after MoE with all gather and reduce scatter.
  • As attention weights are stored in normal TP, no extra memory cost for duplicated weights. Also Decode path can run with normal TP.

Prefill performance are optimized without hurting decode.

Test Plan

GLM 5.2 600k-600
image

Test Result

whx-sjtu added 7 commits July 13, 2026 05:17
Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
(cherry picked from commit c8ad682)
Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
(cherry picked from commit 659dbd9)
Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
Signed-off-by: whx-sjtu <xiaowang990929@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every eligible PR before approval:

  • ✅ Pre Checkin: Black, Ruff, catalog schema validation, non-GPU unit tests

Heavy model tests:

  • ✅ Run after the PR is approved and Pre Checkin passes
  • ✅ Run immediately when an approval review is submitted
  • ✅ Can be requested before approval with labels
Label Tests
ci:full Run all heavy PR model tests: native ATOM, vLLM, and SGLang
ci:atom Run native ATOM model accuracy tests
ci:vllm Run ATOM vLLM OOT model accuracy tests
ci:sglang Run ATOM SGLang model accuracy tests

Heavy jobs are skipped when the PR is not approved and no matching ci:* label is present.
Add labels via the sidebar or gh pr edit 1618 --add-label <label>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant