Skip to content

[atom-sgl-benchmark] Add manual OOB selection and Minimax-M3 for SGLang MI355 benchmark #1671

Open
junyyang-amd wants to merge 4 commits into
mainfrom
yjy/modify_options_for_mi355
Open

[atom-sgl-benchmark] Add manual OOB selection and Minimax-M3 for SGLang MI355 benchmark #1671
junyyang-amd wants to merge 4 commits into
mainfrom
yjy/modify_options_for_mi355

Conversation

@junyyang-amd

Copy link
Copy Markdown
Contributor

Motivation

  1. Add manual OOB tier selection for ATOM-SGLang MI355 benchmarks.
  2. Add minimax-m3 for ATOM-SGLang benchmark.

@junyyang-amd
junyyang-amd requested a review from zhuyuhua-v July 22, 2026 12:38
@github-actions

Copy link
Copy Markdown
Contributor

🏷️ CI Guide

Runs automatically on every eligible PR before approval:

  • ✅ Pre Checkin: Black, Ruff, catalog schema validation, non-GPU unit tests

Heavy model tests:

  • ✅ Run after the PR is approved and Pre Checkin passes
  • ✅ Run immediately when an approval review is submitted
  • ✅ Can be requested before approval with labels
Label Tests
ci:full Run all heavy PR model tests: native ATOM, vLLM, and SGLang
ci:atom Run native ATOM model accuracy tests
ci:vllm Run ATOM vLLM OOT model accuracy tests
ci:sglang Run ATOM SGLang model accuracy tests

Heavy jobs are skipped when the PR is not approved and no matching ci:* label is present.
Add labels via the sidebar or gh pr edit 1671 --add-label <label>

@junyyang-amd
junyyang-amd force-pushed the yjy/modify_options_for_mi355 branch 2 times, most recently from a27a019 to c2f6aba Compare July 22, 2026 12:55
@junyyang-amd
junyyang-amd force-pushed the yjy/modify_options_for_mi355 branch from c2f6aba to 90e33b3 Compare July 22, 2026 15:21
zhangxinyuanliuhengyu added a commit that referenced this pull request Jul 22, 2026
This reverts commit ac2a67c, reversing
changes made to b025be7.
"prefix": "minimax-m3-mxfp4-tp4",
"extra_args": [
"trust_remote_code",
"--tensor-parallel-size 4 --attention-backend aiter --page-size 128 --mem-fraction-static 0.8 --context-length 32768 --max-running-requests 128 --disable-radix-cache --disable-cuda-graph"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please refer args in this pr #1628

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have already made modifications based on the PR. Please review again.

@zhuyuhua-v zhuyuhua-v Jul 23, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update m3 recipe here: https://github.com/ROCm/ATOM/blob/main/recipes/atom_sglang/MiniMax-M3.md could you please help also add nightly test cases?

@junyyang-amd
junyyang-amd force-pushed the yjy/modify_options_for_mi355 branch from 90e33b3 to 9f340bd Compare July 23, 2026 03:03
@zufayu
zufayu requested a review from valarLip July 24, 2026 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants