CI: Add workflow_dispatch input for aiter branch in atom-test#360
Draft
gyohuangxin wants to merge 2 commits intomainfrom
Draft
CI: Add workflow_dispatch input for aiter branch in atom-test#360gyohuangxin wants to merge 2 commits intomainfrom
gyohuangxin wants to merge 2 commits intomainfrom
Conversation
Made-with: Cursor
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a workflow_dispatch input to let CI builds pick a specific ROCm/aiter branch when constructing the CI image.
Changes:
- Introduces
workflow_dispatch.inputs.aiter_branchwith defaultmain. - Adds
AITER_GIT_REFenv var and uses it ingit clone -b ...to select the requested branch. - Makes
GITHUB_COMMIT_SHAmore robust by falling back togithub.sha.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+33
to
+34
| # workflow_dispatch: inputs.aiter_branch; otherwise main (matches previous default-branch shallow clone) | ||
| AITER_GIT_REF: ${{ github.event_name == 'workflow_dispatch' && inputs.aiter_branch || 'main' }} |
| RUN mv jq /usr/local/bin/jq | ||
| RUN rm -rf /app/aiter-test | ||
| RUN git clone --depth 1 https://github.com/ROCm/aiter.git /app/aiter-test && \\ | ||
| RUN git clone --depth 1 -b ${{ env.AITER_GIT_REF }} https://github.com/ROCm/aiter.git /app/aiter-test && \\ |
| RUN pip show pybind11 | ||
| RUN rm -rf /app/aiter-test | ||
| RUN git clone https://github.com/ROCm/aiter.git /app/aiter-test && \\ | ||
| RUN git clone --depth 1 -b ${{ env.AITER_GIT_REF }} https://github.com/ROCm/aiter.git /app/aiter-test && \\ |
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.