Open
Conversation
Signed-off-by: fsx950223 <fsx950223@outlook.com> Made-with: Cursor
The C++ binding does not yet support the pred parameter. Only pass it when pred is not None to avoid TypeError on the current .so. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds autotuning support and thread-local compiler “hint” propagation so kernel compilation can be influenced by autotune-selected parameters (e.g., VGPR limit / waves-per-EU), while also instrumenting more DSL ops via @traced_op and tightening debug-info behavior.
Changes:
- Introduce
autotune/ConfigAPI to benchmark multiple configs and cache the best. - Add thread-local
CompilationContextcompile hints and thread them intogpu-module-to-binaryoptions. - Decorate additional DSL op wrappers with
@traced_opand disable debug info by default.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| python/flydsl/utils/env.py | Changes default debug-info emission behavior. |
| python/flydsl/expr/vector.py | Adds @traced_op to vector helpers. |
| python/flydsl/expr/utils/arith.py | Adds @traced_op to arith utility helpers. |
| python/flydsl/expr/rocdl/init.py | Adds @traced_op to ROCDL op wrappers. |
| python/flydsl/expr/primitive.py | Adjusts copy_atom_call argument passing when pred is unset. |
| python/flydsl/expr/buffer_ops.py | Adds @traced_op to buffer resource/load/store APIs (and imports it). |
| python/flydsl/expr/arith.py | Adds @traced_op to cmp wrappers. |
| python/flydsl/compiler/kernel_function.py | Adds thread-local storage for compile hints. |
| python/flydsl/compiler/jit_function.py | Plumbs debug/hints into MLIR pass pipeline and gpu-module-to-binary opts. |
| python/flydsl/autotune.py | New autotuner implementation, benchmarking + disk cache. |
| python/flydsl/_mlir | Adds a link/redirect to built MLIR Python package location. |
| python/flydsl/init.py | Exposes autotune / Config at package top-level. |
Comments suppressed due to low confidence (2)
python/flydsl/compiler/jit_function.py:1
all_optscan contain spaces (e.g.,"-g --amdgpu-waves-per-eu=..."). MLIR pass pipeline parsing typically requires string-valued options containing spaces to be quoted/escaped; otherwisePassManager.parse(...)can fail or misparse. Consider emittingopts="..."(with proper escaping) when non-empty, or omitting theopts=field entirely whenall_optsis empty to preserve the priorgpu-module-to-binary{format=fatbin}behavior.
import ctypes
python/flydsl/_mlir:1
- This looks like it is intended to be a symlink to the build output. If it is checked in as a regular file (not mode
120000symlink), Python imports offlydsl._mlirwill fail (the file content is not valid Python). Ensure the repository records this as a symlink (and consider the portability impact on platforms/environments that don’t preserve symlinks).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+328
to
330
| *((['ensure-debug-info-scope-on-llvm-func{emission-kind=LineTablesOnly}'] if env.debug.enable_debug_info else [])), | ||
| f"gpu-module-to-binary{{format=fatbin opts={all_opts}}}", | ||
| ] |
Comment on lines
+8
to
+11
| try: | ||
| import torch | ||
| except ImportError: | ||
| torch = None |
Comment on lines
+83
to
+85
| if quantiles: | ||
| return [times[int(q * len(times))] for q in quantiles] | ||
| return times[len(times) // 2] |
Comment on lines
+3
to
+6
| import hashlib, json, os, time, inspect, threading | ||
| from pathlib import Path | ||
| from typing import List, Optional, Dict, Callable, Any, Tuple | ||
| from functools import wraps |
Comment on lines
+257
to
+262
| def _save_disk_cache(self): | ||
| self._cache_file.parent.mkdir(parents=True, exist_ok=True) | ||
| data = {} | ||
| for key, config in self.cache.items(): | ||
| data[json.dumps(list(key))] = config.to_dict() | ||
| self._cache_file.write_text(json.dumps(data, indent=2)) |
| flags |= (1 << 24) # reserved bit, must be 1 on RDNA | ||
| flags |= (2 << 28) # OOB_SELECT = 2 (no bounds checking) | ||
| return flags | ||
| from .meta import traced_op |
coderfeli
reviewed
Mar 19, 2026
| "reconcile-unrealized-casts", | ||
| "gpu-module-to-binary{format=fatbin}", | ||
| *((['ensure-debug-info-scope-on-llvm-func{emission-kind=LineTablesOnly}'] if env.debug.enable_debug_info else [])), | ||
| f"gpu-module-to-binary{{format=fatbin opts={all_opts}}}", |
Collaborator
There was a problem hiding this comment.
fix the while space issue copilot suggest
- Quote opts= value in gpu-module-to-binary pass to handle spaces correctly - Remove python/flydsl/_mlir symlink from git tracking, add to .gitignore - Replace set/clear_compile_hints with thread-safe context manager - Deduplicate compile hints logic in Autotuner via _run_with_hints helper
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
FLYDSL_DEBUG_ENABLE_DEBUG_INFO=true rocprofv3 -i input.yaml -- python /FlyDSL/kernels/rmsnorm_kernel.py
Test Result
Submission Checklist