Open
Conversation
micmelesse
requested review from
a team,
brunomazzottiamd and
Copilot
and removed request for
Copilot
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
micmelesse
force-pushed
the
micmelesse/fp8_bwd_bench
branch
from
18dfa5d to
6c1ee57
Compare
1 task
brunomazzottiamd
approved these changes
Mar 19, 2026
| if sm_scale is None: | ||
| sm_scale = 1.0 / (D_HEAD**0.5) | ||
|
|
||
| # Test mode: run tests from op_tests with specified shapes |
Contributor
There was a problem hiding this comment.
I'm glad you removed this...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This pr fixes some issues with bench_mha and use it collect numbers for fp8 versus fp16 bwd.
Technical Details
Test Plan
Test Result
Submission Checklist