Open
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the fused Q/K RoPE + concat + cache CUDA/HIP kernel path away from ck_tile vector conversion utilities toward OPUS-based casting/conversion (aiter::scaled_cast, opus::cast) and introduces an OPUS-specific dtype dispatch macro to instantiate kernels with OPUS scalar types.
Changes:
- Update
cache_kernels.cuto useaiter::scaled_cast/opus::castand switch kernel instantiation toDISPATCH_BY_KV_CACHE_QUERY_DTYPE_OPUS. - Add
DISPATCH_BY_KV_CACHE_QUERY_DTYPE_OPUSmacro inquant_utils.cuhfor OPUS type dispatch. - Extend
aiter_opus_plus.hwith scaled conversion helpers and add#pragma oncewhere missing.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 9 comments.
| File | Description |
|---|---|
| csrc/kernels/cache_kernels.cu | Replace ck_tile conversion/casts with OPUS equivalents and switch dtype dispatch to OPUS. |
| csrc/include/quant_utils.cuh | Add OPUS variant of KV-cache/query dtype dispatch macro. |
| csrc/include/hip_reduce.h | Add #pragma once and update copyright year. |
| csrc/include/aiter_opus_plus.h | Add #pragma once and introduce OPUS-based scaled conversion utilities (scaled_cast). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tiny/bits) Supports fp32, fp16, bf16, fp8, bf8, fp4, e8m0 with gfx950/gfx942 specializations. Verified bitwise against torch.finfo on both MI355 (gfx950) and MI308 (gfx942).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist