Discard check_LLVM_MAIN_REVISION object file#2345
Merged
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
valarLip
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When running diffusion workloads on MI300/MI355 an unknown object file
.-okept being created in the current working directory. It was traced back to a functioncheck_LLVM_MAIN_REVISION()which was introduced in #1703 and is hit during JIT compilation of aiter kernels.This PR introduces a minimal fix to prevent this stray .-o object file from being created during aiter JIT compilation without affecting the LLVM revision check logic.
Technical Details
The
check_LLVM_MAIN_REVISION()function inaiter/jit/core.pycompiles a small test snippet using hipcc via stdin.When hipcc is invoked with -c (compile-only) it derives the output object filename from the input filename. Because the input here is stdin (denoted by the trailing -), the compiler treats the filename as - and writes -.o into the current directory. That file is a side-effect and never referenced/consumed; the function only cares about the exit code.
The fix is minimal (discarding the object file using
-o /dev/nullas is done inhip_flag_checkerin the same file).Test Plan
Test Result
Submission Checklist