Skip to content

fix(car): shfl and ag dispatch#2346

Open
TennyWang1223 wants to merge 1 commit intomainfrom
fix_shfl_ag_dispatch
Open

fix(car): shfl and ag dispatch#2346
TennyWang1223 wants to merge 1 commit intomainfrom
fix_shfl_ag_dispatch

Conversation

@TennyWang1223
Copy link
Contributor

Motivation

hip shfl runs opus::fp16_t and opus::bf16_t error
allgather dispatch logic needs a branch fallback to rccl

Technical Details

replace __shfl() by ds_bpermute
add fallback logic in framework

Test Plan

see ar and ag single test script

Test Result

rccl fallback success

Submission Checklist

Signed-off-by: root <root@hjbog-srdc-24.amd.com>
@TennyWang1223 TennyWang1223 requested review from a team and valarLip March 19, 2026 07:14
@github-actions
Copy link
Contributor

🏷️ CI Guide

Runs automatically on every PR:

  • ✅ Pre-checks (submodule verification, code formatting)
  • ✅ Aiter op tests (gfx942 + gfx950)
  • ✅ Triton tests (only when aiter/ops/triton/** or related paths are changed)

Extended tests (opt-in via labels):

Label Tests
ci:sglang SGLang integration tests
ci:atom ATOM benchmark (DeepSeek-R1 + GPT-OSS)
ci:vllm vLLM benchmark
ci:all All of the above

Add labels via the sidebar or gh pr edit 2346 --add-label <label>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants