CI: Switch Triton tests from MI325 to MI355 runners#2347
Open
gyohuangxin wants to merge 2 commits intomainfrom
Open
CI: Switch Triton tests from MI325 to MI355 runners#2347gyohuangxin wants to merge 2 commits intomainfrom
gyohuangxin wants to merge 2 commits intomainfrom
Conversation
Contributor
🏷️ CI GuideRuns automatically on every PR:
Extended tests (opt-in via labels):
|
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Triton CI workflow to run on MI355 runners and adjusts the Triton build/test environment to accommodate the new runner behavior.
Changes:
- Switch Triton test shards from MI325 (
aiter-1gpu-runner) to MI355 (linux-aiter-mi355-1) and surface runner label in the job name. - Run Triton pytest with
TRITON_HIP_USE_ASYNC_COPY=0in the container. - Change Triton installation to default to the latest upstream
triton-lang/tritonbranch tip unlessTRITON_COMMITis explicitly set.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/triton-test.yaml |
Moves Triton CI shards to MI355 runners and tweaks the test invocation environment. |
.github/scripts/build_aiter_triton.sh |
Alters Triton installation behavior to default to unpinned upstream unless overridden. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+25
to
+31
| # Use latest triton main by default; override with TRITON_COMMIT env var. | ||
| TRITON_COMMIT=${TRITON_COMMIT:-} | ||
| git clone https://github.com/triton-lang/triton || true | ||
| cd triton | ||
| git checkout "$TRITON_COMMIT" | ||
| if [[ -n "$TRITON_COMMIT" ]]; then | ||
| git checkout "$TRITON_COMMIT" | ||
| fi |
| @@ -189,7 +189,7 @@ jobs: | |||
| set -ex | |||
| echo "Running Triton Tests..." | |||
| docker exec -w /workspace triton_test mkdir -p test-reports | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2312