Skip to content

[Feature] Fixing some CMakeLists.txt issues #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gcapodagAMD wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Feature] Fixing some CMakeLists.txt issues #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ if (BUILD_SPARSE)
GPU_TARGETS=${CMAKE_HIP_ARCHITECTURES}
CMAKE_C_COMPILER=${CMAKE_C_COMPILER}
CMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
CMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH}
CMAKE_PREFIX_PATH="${CMAKE_PREFIX_PATH}"
CMAKE_HIP_ARCHITECTURES=${CMAKE_HIP_ARCHITECTURES}
BINDIR=${CMAKE_CURRENT_BINARY_DIR}
INCLUDEDIR="${DGL_INCLUDE_DIRS}"
Expand Down Expand Up @@ -641,7 +641,6 @@ if (BUILD_GRAPHBOLT)
PYTORCH_ROCM_ARCH=${CMAKE_HIP_ARCHITECTURES}
CMAKE_C_COMPILER=${CMAKE_C_COMPILER}
CMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER}
CMAKE_PREFIX_PATH=${CMAKE_PREFIX_PATH}
GPU_TARGETS=${CMAKE_HIP_ARCHITECTURES}
CMAKE_HIP_ARCHITECTURES=${CMAKE_HIP_ARCHITECTURES}
USE_HIP=${USE_HIP}
Expand Down
11 changes: 9 additions & 2 deletions dgl_sparse/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,19 @@ if [ -n "$CMAKE_CXX_COMPILER" ]; then
CMAKE_COMPILER_FLAGS="$CMAKE_COMPILER_FLAGS -DCMAKE_CXX_COMPILER=$CMAKE_CXX_COMPILER"
fi

# Use CMAKE_PREFIX_PATH from parent if provided (helps find ROCm components)
# Use CMAKE_PREFIX_PATH from parent if provided (helps find ROCm components).
# CMake's add_custom_target converts semicolons to spaces; convert back for -D flag.
CMAKE_PREFIX_FLAGS=""
if [ -n "$CMAKE_PREFIX_PATH" ]; then
CMAKE_PREFIX_FLAGS="-DCMAKE_PREFIX_PATH=$CMAKE_PREFIX_PATH"
CMAKE_PREFIX_SEMICOLON="${CMAKE_PREFIX_PATH// /;}"
CMAKE_PREFIX_FLAGS="-DCMAKE_PREFIX_PATH=${CMAKE_PREFIX_SEMICOLON}"
fi

# Unset CFLAGS/CXXFLAGS inherited from parent — they contain -Werror which
# breaks CMake's FindOpenMP test compilation.
unset CFLAGS
unset CXXFLAGS

if [ "$USE_CUDA" = 'ON' ]; then
CMAKE_FLAGS="-DCUDA_TOOLKIT_ROOT_DIR=$CUDA_TOOLKIT_ROOT_DIR -DTORCH_CUDA_ARCH_LIST=$TORCH_CUDA_ARCH_LIST -DUSE_CUDA=$USE_CUDA -DEXTERNAL_DMLC_LIB_PATH=$EXTERNAL_DMLC_LIB_PATH"
elif [ "$USE_HIP" = 'ON' ]; then
Expand Down
11 changes: 9 additions & 2 deletions graphbolt/build_rocm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,19 @@ if [ -n "$CMAKE_CXX_COMPILER" ]; then
CMAKE_COMPILER_FLAGS="$CMAKE_COMPILER_FLAGS -DCMAKE_CXX_COMPILER=$CMAKE_CXX_COMPILER"
fi

# Use CMAKE_PREFIX_PATH from parent if provided (helps find ROCm components)
# Use CMAKE_PREFIX_PATH from parent if provided (helps find ROCm components).
# CMake's add_custom_target converts semicolons to spaces; convert back for -D flag.
CMAKE_PREFIX_FLAGS=""
if [ -n "$CMAKE_PREFIX_PATH" ]; then
CMAKE_PREFIX_FLAGS="-DCMAKE_PREFIX_PATH=$CMAKE_PREFIX_PATH"
CMAKE_PREFIX_SEMICOLON="${CMAKE_PREFIX_PATH// /;}"
CMAKE_PREFIX_FLAGS="-DCMAKE_PREFIX_PATH=${CMAKE_PREFIX_SEMICOLON}"
fi

# Unset CFLAGS/CXXFLAGS inherited from parent — they contain -Werror which
# breaks CMake's FindOpenMP test compilation. Graphbolt sets its own flags via Torch.
unset CFLAGS
unset CXXFLAGS

CMAKE_FLAGS="-DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
-DCMAKE_HIP_ARCHITECTURES=${CMAKE_HIP_ARCHITECTURES} \
-DUSE_HIP=$USE_HIP \
Expand Down
Loading