GEMM+GEMM and CONV+GEMM support to quickTuningGen and GEMM+GEMM quick tuning list#2262
Open
dorde-antic wants to merge 11 commits intodevelopfrom
Open
GEMM+GEMM and CONV+GEMM support to quickTuningGen and GEMM+GEMM quick tuning list#2262dorde-antic wants to merge 11 commits intodevelopfrom
dorde-antic wants to merge 11 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds two groups of changes: (1) updates the rocprofv3 profiler invocation in perfRunner.py and tuningRunner.py to use the correct --output-format csv flag (replacing the old -f csv flag), and (2) extends quickTuningGen.py to handle gemm_gemm and conv_gemm operations, and adds the corresponding GEMM+GEMM quick tuning parameter arrays for gfx908 (f16, f32) and gfx1200 (f16) architectures to QuickTuningPerfconfigs.inc.
Changes:
- Updated rocprofv3 flag from
-f csvto--output-format csvacross performance runner scripts - Added GEMM+GEMM and CONV+GEMM operation support in the
quickTuningGen.pycode generator - Added GEMM+GEMM quick tuning parameter lists for
gfx908andgfx1200to the.incfile
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
mlir/utils/performance/perfRunner.py |
Updates rocprofv3 --output-format csv flag in two profiler invocations |
mlir/utils/performance/tuningRunner.py |
Same rocprofv3 flag update in verification pipeline |
mlir/utils/performance/analysis/quickTuningGen.py |
Adds column definitions and full code-generator support for gemm_gemm and conv_gemm ops |
mlir/include/mlir/Dialect/Rock/Tuning/QuickTuningPerfconfigs.inc |
Adds GEMM+GEMM quick tuning parameter arrays and lookup entries for gfx908 (f16, f32) and gfx1200 (f16) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Quick tuning locally
tuningRunner and perfRunner in general
CI
Test Result
Quick tuning locally ✅
PR CI
Weekly CI
Nightly CI
Submission Checklist