[AIROCMLIR-445] Lower `linalg.generic` Backwards Conv into `rock.bwd_data_conv` by Mr-Anyone · Pull Request #2274 · ROCm/rocMLIR

Mr-Anyone · 2026-03-09T15:46:11Z

Motivation

Being able to lower a linalg.generic into rock.bwd_data_conv.

Technical Details

Essentially, we are converting a linalg.generic with a NGC*, GFC*, and NGF* into its equivalent form in rock.bwd_data_conv. There are only two special cases: backward convolution with padding, and backward convolution with dilation and strides which case the result tensor to have empty values.

If we have padding, we first remove the padding from the code structure.

%backward_conv = linalg.generic ins(...) outs(...)  // compute backward convolution
%collapsed_group = tensor.collapse_shape %backward_conv // collapsing group dimension
%handle_padding= tensor.extract_slice %collapsed_group // handle padding

to

%1 = rock.conv_bwd_data(%expanded_2, %0, %expanded_1) .... // compute backwards convolution
%collapsed = tensor.collapse_shape %0 [[0], [1, 2], [3], [4]] : // collapsing group dimensions

Here, we have remove the tensor.extract_slice, which is the padding from the linalg pipeline as rock.conv_bwd_data handles that for us.

In the cases that we need to prefill the result tensor, we emit a rock.prefill attribute like the one found in tosa pipeline. As of current, this is hard coded as we assume the result tensor will always be at the 0th index.

Test Plan

Added e2e test for linalg to rock.

Test Result

Pass all e2e test.

Submission Checklist

Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.

Copilot

Pull request overview

This PR extends the Linalg-to-Rock conversion to lower certain backward-data convolution linalg.generic ops into rock.conv_bwd_data (rock.bwd_data_conv) and updates e2e fusion tests to exercise the new lowering pipeline.

Changes:

Add a dedicated BwdConvLinalgConverter to rewrite backward-data conv linalg.generic into rock::ConvBwdDataOp.
Extend spatial-dimension handling to include backward conv op types.
Update multiple mixr-bwd-data-conv* e2e MLIR tests with additional (intended) RUN pipelines.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
mlir/lib/Conversion/LinalgToRock/LinalgToRock.cpp	Adds backward-data conv lowering and hooks it into the conversion pattern population.
mlir/test/fusion/pr-e2e/mixr-bwd-data-conv3d.mlir	Adds an (currently disabled) RUN line intended to test the migraphx-linalg pipeline.
mlir/test/fusion/pr-e2e/mixr-bwd-data-conv.mlir	Adds an additional enabled RUN line and an additional disabled RUN line for alternative pipelines.
mlir/test/fusion/pr-e2e/mixr-bwd-data-conv-stride32.mlir	Adds an (currently disabled) RUN line intended to test the migraphx-linalg pipeline.
mlir/test/fusion/pr-e2e/mixr-bwd-data-conv-stride2-dilation2.mlir	Adds an (currently disabled) RUN line intended to test the migraphx-linalg pipeline.
mlir/test/fusion/pr-e2e/mixr-bwd-data-conv-padding1.mlir	Adds an (currently disabled) RUN line intended to test the migraphx-linalg pipeline.
mlir/test/fusion/pr-e2e/mixr-bwd-data-conv-dilation2-stride1.mlir	Adds an (currently disabled) RUN line intended to test the migraphx-linalg pipeline.
mlir/test/fusion/pr-e2e/mixr-bwd-data-conv-dilation1-stride2.mlir	Adds an (currently disabled) RUN line intended to test the migraphx-linalg pipeline.
mlir/test/fusion/pr-e2e/mixr-bwd-data-conv-asymmetric-stride.mlir	Adds an (currently disabled) RUN line intended to test the migraphx-linalg pipeline.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

mlir/test/fusion/pr-e2e/mixr-bwd-data-conv-stride32.mlir

@@ -1,5 +1,6 @@
 // RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx,highlevel -host-pipeline=migraphx,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s
 // RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx,highlevel -host-pipeline=migraphx-linalg,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s
+//RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx-linalg,highlevel -host-pipeline=migraphx,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s


mlir/test/fusion/pr-e2e/mixr-bwd-data-conv-stride2-dilation2.mlir

@@ -1,5 +1,6 @@
 // RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx,highlevel -host-pipeline=migraphx,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s
 // RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx,highlevel -host-pipeline=migraphx-linalg,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s
+//RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx-linalg,highlevel -host-pipeline=migraphx-linalg,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s


mlir/test/fusion/pr-e2e/mixr-bwd-data-conv-dilation1-stride2.mlir

@@ -1,5 +1,6 @@
 // RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx,highlevel -host-pipeline=migraphx,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s
 // RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx,highlevel -host-pipeline=migraphx-linalg,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s
+//RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx-linalg,highlevel -host-pipeline=migraphx,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s


mlir/lib/Conversion/LinalgToRock/LinalgToRock.cpp

+      /*gridSize=*/nullptr, conv.padding, conv.stride, conv.dilation,
+      /*params=*/nullptr, rewriter.getIndexAttr(0),
+      /*usesV4R1=*/rewriter.getBoolAttr(false));
+  setConvLayoutAttrs(rewriter, cop, getSpatialDim(conv.type));


mlir/lib/Conversion/LinalgToRock/LinalgToRock.cpp

mlir/test/fusion/pr-e2e/mixr-bwd-data-conv-dilation2-stride1.mlir

@@ -1,5 +1,6 @@
 // RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx,highlevel -host-pipeline=migraphx,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s
 // RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx,highlevel -host-pipeline=migraphx-linalg,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s
+//RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx-linalg,highlevel -host-pipeline=migraphx,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s


mlir/test/fusion/pr-e2e/mixr-bwd-data-conv-asymmetric-stride.mlir

@@ -1,5 +1,6 @@
 // RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx,highlevel -host-pipeline=migraphx,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s
 // RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx,highlevel -host-pipeline=migraphx-linalg,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s
+//RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx-linalg,highlevel -host-pipeline=migraphx,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s


mlir/test/fusion/pr-e2e/mixr-bwd-data-conv-padding1.mlir

@@ -1,5 +1,6 @@
 // RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx,highlevel -host-pipeline=migraphx,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s
 // RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx,highlevel -host-pipeline=migraphx-linalg,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s
+//RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx-linalg,highlevel -host-pipeline=migraphx,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s


mlir/lib/Conversion/LinalgToRock/LinalgToRock.cpp

mlir/test/fusion/pr-e2e/mixr-bwd-data-conv3d.mlir

@@ -1,5 +1,6 @@
 // RUN: sed s/##TOKEN_ARCH##/%arch/g %s | rocmlir-driver -kernel-pipeline migraphx,highlevel | rocmlir-gen -ph -print-results -rand none - | rocmlir-driver -arch %arch -c  | mlir-runner -O2 --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext --entry-point-result=void | FileCheck %s --check-prefix=MIXR
 // RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx,highlevel -host-pipeline=migraphx-linalg,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s --check-prefix=LINALG
+//RUN: rocmlir-gen -fut mlir_bwd_data_conv --arch %arch --clone-harness %s | rocmlir-driver -kernel-pipeline=migraphx-linalg,highlevel -host-pipeline=migraphx-linalg,highlevel -targets %arch | rocmlir-gen -ph -rand 1 -rand_type float -fut mlir_bwd_data_conv_wrapper --verifier clone -relDiff_threshold 0.00001 - | rocmlir-driver -host-pipeline mhal,runner -kernel-pipeline full -targets %arch  | xmir-runner --shared-libs=%linalg_test_lib_dir/libmlir_rocm_runtime%shlibext,%conv_validation_wrapper_library_dir/libconv-validation-wrappers%shlibext,%linalg_test_lib_dir/libmlir_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_float16_utils%shlibext,%linalg_test_lib_dir/libmlir_c_runner_utils%shlibext,%linalg_test_lib_dir/libmlir_async_runtime%shlibext --entry-point-result=void | FileCheck %s --check-prefix=LINALG


umangyadav · 2026-03-13T13:24:44Z

mlir/lib/Conversion/LinalgToRock/LinalgToRock.cpp

+  if (failed(maybeConv))
+    return failure();
+
+  ConvFields conv = *maybeConv;


can you add lit tests ?

umangyadav · 2026-03-13T13:25:02Z

mlir/lib/Conversion/LinalgToRock/LinalgToRock.cpp

+    return cast<IntegerAttr>(attr).getInt() != 0;
+  });
+
+  // FIXME: add a check here!


can you add this checks ?

The checks was that I have to remove the padding, which I have just done.

umangyadav · 2026-03-13T13:25:20Z

mlir/lib/Conversion/LinalgToRock/LinalgToRock.cpp

+  // to do here.
+  if (!rock::isEveryElementWrittenBwdData(strideDims, dilationDims,
+                                          filterDims)) {
+    // FIXME: don't hard code this - see PR#1687


is this FIXME relevant ?

Currently, I have hard coded this to the first output with Type funcResType=func.getFunctionType().getResult(0);

My understanding of mlir is that there can be multiple output. In those cases, we have to climb a tree to figure which of the output we need to set rock.prefill attribute?

Mr-Anyone requested a review from causten as a code owner March 9, 2026 15:46

Mr-Anyone requested review from dhernandez0, justinrosner, pabloantoniom and umangyadav March 9, 2026 15:47

Mr-Anyone force-pushed the pr-template-migraphx-to-linalg-conv-backward-2 branch from 3fef186 to f6ddf93 Compare March 9, 2026 15:49

Mr-Anyone force-pushed the pr-template-migraphx-to-linalg-conv-backward branch from 3a87aa5 to 6113ca7 Compare March 9, 2026 16:10

Mr-Anyone force-pushed the pr-template-migraphx-to-linalg-conv-backward-2 branch 2 times, most recently from 5cc0068 to c7b73fc Compare March 10, 2026 19:14

Mr-Anyone force-pushed the pr-template-migraphx-to-linalg-conv-backward branch from 6113ca7 to 75b2f75 Compare March 10, 2026 19:14

umangyadav requested a review from Copilot March 13, 2026 13:16

Copilot started reviewing on behalf of umangyadav March 13, 2026 13:19 View session

Copilot AI reviewed Mar 13, 2026

View reviewed changes

umangyadav reviewed Mar 13, 2026

View reviewed changes

Mr-Anyone force-pushed the pr-template-migraphx-to-linalg-conv-backward-2 branch from c7b73fc to 97f7c5e Compare March 13, 2026 18:28

Mr-Anyone force-pushed the pr-template-migraphx-to-linalg-conv-backward branch 2 times, most recently from 1ee8514 to c0b962d Compare March 16, 2026 13:34

Mr-Anyone force-pushed the pr-template-migraphx-to-linalg-conv-backward-2 branch 2 times, most recently from 7582d42 to 2d3e9da Compare March 16, 2026 13:53

Mr-Anyone force-pushed the pr-template-migraphx-to-linalg-conv-backward branch from c0b962d to b5efca6 Compare March 16, 2026 13:54

Mr-Anyone force-pushed the pr-template-migraphx-to-linalg-conv-backward-2 branch 2 times, most recently from f5a843e to 517cf56 Compare March 16, 2026 18:51

Mr-Anyone added 2 commits March 16, 2026 20:06

Lower linalg.generic Backwards Conv into rock.conv

b0ba480

Address comments first round

78cda38

Mr-Anyone force-pushed the pr-template-migraphx-to-linalg-conv-backward-2 branch from 517cf56 to 78cda38 Compare March 16, 2026 20:06

Mr-Anyone force-pushed the pr-template-migraphx-to-linalg-conv-backward branch from 86e51ef to 2d94bfc Compare March 16, 2026 20:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AIROCMLIR-445] Lower `linalg.generic` Backwards Conv into `rock.bwd_data_conv`#2274

[AIROCMLIR-445] Lower `linalg.generic` Backwards Conv into `rock.bwd_data_conv`#2274
Mr-Anyone wants to merge 2 commits intopr-template-migraphx-to-linalg-conv-backwardfrom
pr-template-migraphx-to-linalg-conv-backward-2

Mr-Anyone commented Mar 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

umangyadav Mar 13, 2026

Uh oh!

umangyadav Mar 13, 2026

Uh oh!

Mr-Anyone Mar 16, 2026

Uh oh!

umangyadav Mar 13, 2026

Uh oh!

Mr-Anyone Mar 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Mr-Anyone commented Mar 9, 2026

Motivation

Technical Details

Test Plan

Test Result

Submission Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

umangyadav Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

umangyadav Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Mr-Anyone Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

umangyadav Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Mr-Anyone Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants