[AIROCMLIR-604] [DRAFT] Fix CK build/benchmarking tests in Nightly CI#2300
Draft
justinrosner wants to merge 2 commits intodevelopfrom
Draft
[AIROCMLIR-604] [DRAFT] Fix CK build/benchmarking tests in Nightly CI#2300justinrosner wants to merge 2 commits intodevelopfrom
justinrosner wants to merge 2 commits intodevelopfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR addresses a build error that was causing the CK nightly comparison to fail, and then also makes sure that any errors are caught and noticeable to the CI (instead of always showing as green).
This implements: https://amd-hub.atlassian.net/browse/AIROCMLIR-604
Technical Details
-DBUILD_TESTS=OFFto the CK cmake options. The nightly pipeline only needs CK's libraries install for benchmarking (it doesn't need the CK test suite)catchError(buildResult: null)withcatchError(buildResult: 'UNSTABLE', stageResult: 'FAILURE'). The previous setting silently swallowed all failures, leaving the overall build green even when the CK stage was completely broken. With this change, the stage is marked as FAILURE (red in stage view) and the build is marked asUNSTABLE(yellow), making CK-related issues visible without failing the entire nightly runTest Plan
Test Result
Submission Checklist