updates from utils/update.r scripts, adding CI paramteres to ei_iter,…

[SeanDLong]

… enabling parallel results for ei_rxc, and creating visualization functions named rpv_toDF() and rpv_coef_plot()

Thanks for opening a PR!

• Have you followed the guidelines in our Contributing Guide?
• Ensured you are not committing large data files or other sensitive information (e.g. voter files)

Please list any Issues this PR addresses

• fixes #

updated the functions in the updates/utils files

[rachel-carroll]

Hey Sean! This looks good, just a few comments below. Also did you run devtools::check()? I think it should have updated documentation if you did which I don't see.

[rachel-carroll]

you need to add the documentation stuff at the beginning. If you look at some other .R function you will see they all start with descriptions of the function overall and the arguments and other parameters. For example @export tag which makes it actually become a seen function of the package for users. Just follow the format in other .R files

[rachel-carroll]

Thanks! looks basically ready, just asked to bring back some of the helpful code comments and some formatting.

[rachel-carroll]

this looks mostly right, one note on preference is that the formatting (spacing and indentation standards) and comments in the eiExpand function are very helpful to keep. I think the only substantive code change was changing #library(eiExpand) to #library(eiCompare) in the commented out documentation examples. Is that right? The rest can match eiExpand i think

[rachel-carroll]

not as familiar with the CI here but do these defaults need to change or become arguments?

[rachel-carroll]

Can probably drop these since the names will always be ci_lower ci_upper now without the _95, right?

[rachel-carroll]

I strongly prefer to keep these comments. The substantive changes will be clreaer and its helpful to have well commented out code

[rachel-carroll]

remove ... argument in function definition

[rachel-carroll]

just fyi looked at this error and its right that the ... has to stay bc its a method versus its own function. Thanks for catching that!

[rachel-carroll]

one more comment! then should be ready to go.

[rachel-carroll]

this looks a little funky some of it got cut off i think. shoudl be

  plotDF <-  rpv_data %>%
    dplyr::mutate(Model = model,
           Jurisdiction = jurisdiction,
           Election_Type = election_type,
           Year = as.numeric(year),
           Contest = contest,
           Candidate = candidate,
           Party = party,
           Preferred_Candidate = preferred_candidate
    ) %>%
    tidyr::pivot_longer(
      cols = grep("\\.", colnames(rpv_data), value = TRUE),
      names_to = c("Voter_Race",".value"),
      names_pattern = "(.*)\\.(.*)",
      names_repair = "unique"
    )

[rachel-carroll]

darn found one more thing. This data is not in eiCompare its in eiExpand. You can see if you can use something from eiCompared internal data. Or move south carolina over to eiCompare.

[rachel-carroll]

now getting an error on this bc rpv_normalize is in eiExpand. I think just remove this part