Open
Conversation
Co-authored-by: sam <sam@webcreative5.net>
…ions Co-authored-by: sam <sam@webcreative5.net>
…port Co-authored-by: sam <sam@webcreative5.net>
- Added `rxjs` as a dependency in the Vue package. - Updated the `packages/vue/package.json` to include new dependencies. - Removed outdated example files related to Vue integration. - Enhanced the configuration for Vue components in the RPGJS framework. - Improved the overall structure of the Vue integration for better maintainability.
- Updated the `RpgClient` interface to allow for a more flexible `gui` property, supporting both structured and any type. - Refactored `RpgClientEngine` to streamline hook subscriptions during initialization. - Improved the `provideVueGui` function to utilize a module creation pattern for better organization. - Added a `mount` method in `VueGui` for improved component lifecycle management. - Updated sample configurations to reflect the new Vue integration structure.
- Deleted `vue-injections-summary.md`, `vue-package-di-summary.md`, and `vue-package-summary.md` as part of the cleanup process. - These files contained detailed documentation on Vue injections and package structure, which are no longer needed. - This change helps streamline the documentation and focuses on the essential components of the project.
- Added functionality to assign the GUI instance to the component in RpgGui, improving component management. - Updated the example Vue component to use a more descriptive name for the rpgGuiClose method, enhancing clarity in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
@rpgjs/vuepackage to enable Vue.js GUI components with full engine service injection, separating them from CanvasEngine components.This PR formalizes the separation of GUI frameworks within RPGJS. The main
RpgGuinow exclusively handles CanvasEngine components, while@rpgjs/vueprovides a dedicated, fully integrated solution for Vue.js, including a robust dependency injection system for all core RPGJS services, making it easier to build complex and reactive UIs.