Skip to content

[lwip][ppp]: fix the risk of name member contamination in the ppp netif #11410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Evlers wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

[lwip][ppp]: fix the risk of name member contamination in the ppp netif #11410

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions components/net/lwip/Kconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,7 @@ if RT_USING_LWIP
config RT_LWIP_NETIF_NAMESIZE
int "netif name length"
default 6
range 3 32

config SO_REUSE
int "Enable SO_REUSEADDR option"
Expand Down
3 changes: 1 addition & 2 deletions components/net/lwip/lwip-2.1.2/src/netif/ppp/ppp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,8 +469,7 @@ static void ppp_do_connect(void *arg) {
* ppp_netif_init_cb - netif init callback
*/
static err_t ppp_netif_init_cb(struct netif *netif) {
netif->name[0] = 'p';
netif->name[1] = 'p';
strncpy(netif->name, "pp", sizeof(netif->name));
#if PPP_IPV4_SUPPORT
netif->output = ppp_netif_output_ip4;
#endif /* PPP_IPV4_SUPPORT */
Expand Down
Loading