Skip to content

[bsp][drivers][soft_spi] unify the software SPI driver#11625

Merged
Rbb666 merged 1 commit into
RT-Thread:masterfrom
CYFS3:soft_spi
Jul 17, 2026
Merged

[bsp][drivers][soft_spi] unify the software SPI driver#11625
Rbb666 merged 1 commit into
RT-Thread:masterfrom
CYFS3:soft_spi

Conversation

@CYFS3

@CYFS3 CYFS3 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

多个 BSP 各自维护软件 SPI 驱动,存在重复实现、总线名称不统一以及板级配置与组件配置割裂的问题。本 PR 将这些 BSP 迁移到组件层通用软件 SPI 驱动。

你的解决方案是什么 (what is your solution)

  • 删除 LPC、Raspberry Pi Pico、Renesas、STM32 和 WCH BSP 中重复的软件 SPI 驱动,统一使用 components/drivers/spi/dev_soft_spi.c
  • 软件总线名称统一为 swspi0swspi6,同步更新设备查找、RTduino 引脚映射和相关说明。
  • 原本具有软件 SPI 配置的 BSP 在 On-chip Peripheral Drivers 中保留板级入口。
  • 板级菜单使用通用 RT_SOFT_SPIx_SCK_PINMISO_PINMOSI_PIN,保留原引脚默认值并允许用户修改。
  • 软件 SPI 子总线默认关闭,由板级消费者或用户显式选择。
  • 分支基于最新 master,并整理为单个提交。

请提供验证的bsp和config (provide the config and bsp)

  • BSP:

    • bsp/nxp/lpc/lpc55sxx/lpc55s69_nxp_evk
    • bsp/raspberry-pico/RP2040
    • bsp/renesas/ra6m3-hmi-board
    • bsp/stm32/stm32f407-atk-explorer
    • bsp/wch/risc-v/ch32v307v-r1
  • .config:

    • CONFIG_RT_USING_SPI=y
    • CONFIG_RT_USING_SOFT_SPI=y
    • CONFIG_RT_USING_SOFT_SPIx=y
    • CONFIG_RT_SOFT_SPIx_SCK_PIN=
    • CONFIG_RT_SOFT_SPIx_MISO_PIN=
    • CONFIG_RT_SOFT_SPIx_MOSI_PIN=
  • 验证结果:

    • git diff rtt/master..HEAD --check 通过。
    • 11/11 个涉及板级入口的 BSP 通过完整 Kconfig 语义检查。
    • 板级默认 SCK/MISO/MOSI 与组件配置一致,并验证可以被用户覆盖。
    • 软件 SPI 消费者未发现绕过板级菜单直接选择组件总线的情况。
    • 相关软件设备名中未保留旧 sspiX 名称。
    • 尚未进行完整硬件实机验证。
  • action:

    • 推送后等待 PR CI 结果。

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用clang-format 源码格式化工具确保格式符合RT-Thread代码规范 This PR has been formatted with clang-format and complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:soft_spi
  • 设置PR number为 \ Set the PR number to:11625
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 soft_spi 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the soft_spi branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added BSP: NXP Code related with NXP BSP: STM32 BSP related with ST/STM32 BSP BSP: Renesas BSP related with Renesas component: drivers/spi BSP: WCH BSP related with WCH Component component: drivers labels Jul 16, 2026
@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: bsp_renesas

Reviewers: @kurisaW

Changed Files (Click to expand)
  • bsp/renesas/libraries/HAL_Drivers/drivers/SConscript
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_soft_spi.c
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_soft_spi.h
  • bsp/renesas/ra6m3-hmi-board/board/Kconfig
  • bsp/renesas/ra6m3-hmi-board/board/rtduino/arduino_pinout/pins_arduino.h

🏷️ Tag: bsp_rt-spark

Reviewers: @Rbb666 @kurisaW

Changed Files (Click to expand)
  • bsp/stm32/stm32f407-rt-spark/applications/arduino_pinout/README.md
  • bsp/stm32/stm32f407-rt-spark/applications/arduino_pinout/pins_arduino.c

🏷️ Tag: bsp_stm32

Reviewers: @Liang1795 @hamburger-os @wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/libraries/HAL_Drivers/drivers/SConscript
  • bsp/stm32/libraries/HAL_Drivers/drivers/drv_soft_spi.c
  • bsp/stm32/libraries/HAL_Drivers/drivers/drv_soft_spi.h
  • bsp/stm32/stm32f407-atk-explorer/board/Kconfig
  • bsp/stm32/stm32f407-atk-explorer/board/ports/soft_spi_flash_init.c
  • bsp/stm32/stm32f407-atk-explorer/board/ports/touch/drv_touch_xpt.c
  • bsp/stm32/stm32f407-atk-explorer/board/ports/touch/drv_xpt2046_init.c
  • bsp/stm32/stm32f407-fk407m2-zgt6/board/Kconfig
  • bsp/stm32/stm32f407-lckfb-skystar/applications/arduino_pinout/README.md
  • bsp/stm32/stm32f407-lckfb-skystar/applications/arduino_pinout/pins_arduino.c
  • bsp/stm32/stm32f407-lckfb-skystar/applications/arduino_pinout/pins_arduino.h
  • bsp/stm32/stm32f407-lckfb-skystar/board/Kconfig
  • bsp/stm32/stm32f407-lckfb-skystar/board/ports/soft_spi_flash_init.c
  • bsp/stm32/stm32f407-rt-spark/applications/arduino_pinout/README.md
  • bsp/stm32/stm32f407-rt-spark/applications/arduino_pinout/pins_arduino.c

📊 Current Review Status (Last Updated: 2026-07-16 17:45 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions

github-actions Bot commented Jul 16, 2026

Copy link
Copy Markdown

@CYFS3
CYFS3 marked this pull request as ready for review July 16, 2026 04:57

@wdfk-prog wdfk-prog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rbb666
Rbb666 merged commit 5363e4e into RT-Thread:master Jul 17, 2026
106 checks passed
@CYFS3
CYFS3 deleted the soft_spi branch July 17, 2026 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: NXP Code related with NXP BSP: Renesas BSP related with Renesas BSP: STM32 BSP related with ST/STM32 BSP: WCH BSP related with WCH BSP component: drivers/spi component: drivers Component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants