Skip to content

Fix GetGlobalSetting #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Raenore merged 2 commits into from
Feb 24, 2026
Merged

Fix GetGlobalSetting #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
716aed5
Fix GetGlobalSetting
Raenore Feb 24, 2026
68069bd
Update CHANGELOG for 0.7.1
Raenore Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@

All notable changes to this project will be documented in this file.

## [0.7.1] - 2026-02-24
Minor patch to fix checking and unchecking global settings.

### Fixed
- Fixed global settings not checking or unchecking due to previous DB updates ([#90](https://github.com/Raenore/Sippy-Cup/pull/90)).

## [0.7.0] - 2026-02-23
Major patch as we move further into the Midnight pre-patch, with improved Prism (Projecting & Reflecting) support and additional secret-related fixes.

Expand Down Expand Up @@ -57,7 +63,8 @@ Given that Sippy Cup never officially supported combat situations, these restric
## Full Changelog
The complete changelog, including older versions, can always be found on [Sippy Cup's GitHub Wiki](https://github.com/Raenore/Sippy-Cup/wiki/Full-Changelog).

[unreleased]: https://github.com/Raenore/Sippy-Cup/compare/0.7.0...HEAD
[unreleased]: https://github.com/Raenore/Sippy-Cup/compare/0.7.1...HEAD
[0.7.1]: https://github.com/Raenore/Sippy-Cup/compare/0.7.0...0.7.1
[0.7.0]: https://github.com/Raenore/Sippy-Cup/compare/0.6.1...0.7.0
[0.6.1]: https://github.com/Raenore/Sippy-Cup/compare/0.6.0...0.6.1
[0.6.0]: https://github.com/Raenore/Sippy-Cup/compare/0.5.3...0.6.0
2 changes: 1 addition & 1 deletion Core/Database.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ function SIPPYCUP.Database.GetGlobalSetting(key)
local global = SIPPYCUP.global;
local def = SIPPYCUP.Database.defaults.global[key];

if not global[key] then
if global[key] == nil then
if type(def) == "table" then
global[key] = global[key] or {};
local t = global[key];
Expand Down