Fixes zero-sum issue after outlier removal#2
Open
LudvigOlsen wants to merge 1 commit intoRafeed-bot:masterfrom
Open
Fixes zero-sum issue after outlier removal#2LudvigOlsen wants to merge 1 commit intoRafeed-bot:masterfrom
LudvigOlsen wants to merge 1 commit intoRafeed-bot:masterfrom
Conversation
This was referenced Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Rafeed,
When using 51-1000bp fragment lengths for a low-coverage file, I run into the issue where
GC_arraybecomes all zeros after outlier removal. The current code checks for zero-sum before enteringconstruct_GC_bias()but not afterremove_outlier().This fixes that by returning an array with
1s (like you do for pre-outlier-removal zero-sums).Best,
Ludvig