feat: enterprise-grade production hardening#12
Merged
Conversation
Security: - Fix token refresh endpoint re-signing with empty email and hardcoded student role; now looks up current user data via findUserById so role changes and correct email are reflected in refreshed tokens - Add findUserById to userRepo (DB + memory fallback) CI pipeline: - Remove `|| true` from api-gateway lint step; failures now block CI - Tighten services lint step to use continue-on-error instead of || true - Pin Trivy to aquasecurity/trivy-action@0.30.0 (was @master) - Set Trivy exit-code to 1 for CRITICAL findings (was 0 / silent) - Add --ci flag to jest coverage run for better reporter output Code quality: - Upgrade ESLint: enable no-explicit-any as error, unused-vars as error, add eqeqeq, no-return-await, prefer-const rules - Remove `as any` cast in courses route (Lesson.content is already typed) - Replace require() with proper import for package.json in health route - Read version from package.json instead of hardcoded string in /health Testing: - Increase test count from 26 to 28: add refresh-carries-real-user-data test and logout test - Add coverage thresholds (60% lines/functions/statements, 28% branches) - Switch jest to --forceExit to prevent open handle hangs in CI Infrastructure: - Fix Grafana port conflict in docker-compose.yml (3001→3030; auth-service was also on 3001) - Remove ngrok.zip binary from git tracking (already in .gitignore)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security:
student role; now looks up current user data via findUserById so role
changes and correct email are reflected in refreshed tokens
CI pipeline:
|| truefrom api-gateway lint step; failures now block CICode quality:
add eqeqeq, no-return-await, prefer-const rules
as anycast in courses route (Lesson.content is already typed)Testing:
test and logout test
Infrastructure:
was also on 3001)