Fixed NoMethodError (undefined method 'empty?' for nil)

[faheemKamboh]

Updated nil? and empty? positions and added specs.

[faheemKamboh]

@eelcoj Hi, could you please help merge this PR and release the version?

[eelcoj]

Interesting @faheemKamboh! Thanks for the PR. What issue was/is this causing?

[faheemKamboh]

What issue was/is this causing?

@eelcoj It turned out that in my case, the provider wasn’t being set properly, which led to a NoMethodError (undefined method 'empty?' for nil) error. Unfortunately, I wasn’t getting the full Rails backtrace, so it took me a while to trace it down. Eventually, I discovered that nil? was being called after empty?, which caused the issue — just a small but tricky mistake.

[eelcoj]

Thanks a bunch for this PR, @faheemKamboh. The first real addition to Courrier from someone else than me! ❤️

[faheemKamboh]

@eelcoj please let me know if I can support with anything; I’d be glad to help.

[eelcoj]

Thanks! Any of the open issues would be worth exploring. I think especially #14 is not too big of a feature? Let me know if you need any guidance/help. 👍

And as you start using Courrier more, you might find other odd thingsbugs. 😊

[faheemKamboh]

I think especially #14 is not too big of a feature? Let me know if you need any guidance/help. 👍

Thanks, @eelcoj. I’ll look into it and reach out if I need any guidance.