Skip to content

Implement remembering Open With choice #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sud0xenn wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implement remembering Open With choice #271

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb4f101
Implement remembering Open With choice
sud0xenn May 22, 2026
bfd5423
Add an import accidentally removed
sud0xenn May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 39 additions & 1 deletion ...com/raival/compose/file/explorer/screen/main/tab/files/ui/dialog/OpenWithAppListDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,15 @@ package com.raival.compose.file.explorer.screen.main.tab.files.ui.dialog
import androidx.compose.animation.AnimatedVisibility
import androidx.compose.animation.animateContentSize
import androidx.compose.foundation.ExperimentalFoundationApi
import androidx.compose.foundation.clickable
import androidx.compose.foundation.combinedClickable
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.itemsIndexed
import androidx.compose.material3.Checkbox
import androidx.compose.material3.DropdownMenu
import androidx.compose.material3.DropdownMenuItem
import androidx.compose.material3.HorizontalDivider
Expand All @@ -22,6 +25,7 @@ import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.runtime.rememberCoroutineScope
import androidx.compose.runtime.setValue
import androidx.compose.ui.Alignment
import androidx.compose.ui.Modifier
import androidx.compose.ui.platform.LocalContext
import androidx.compose.ui.res.stringResource
Expand Down Expand Up @@ -67,6 +71,10 @@ fun OpenWithAppListDialog(
mutableStateOf(true)
}

val rememberChoice = remember {
mutableStateOf(false)
}

val scope = rememberCoroutineScope()

fun loadActivities(mimeType: String) {
Expand Down Expand Up @@ -129,6 +137,23 @@ fun OpenWithAppListDialog(
)
}

Row(
modifier = Modifier
.fillMaxWidth()
.clickable(
onClick = { rememberChoice.value = !rememberChoice.value }
)
.padding(horizontal = 16.dp, vertical = 8.dp),
verticalAlignment = Alignment.CenterVertically
) {
Checkbox(
checked = rememberChoice.value,
onCheckedChange = { rememberChoice.value = it }
)
Space(8.dp)
Text(text = stringResource(id = R.string.remember_this_choice))
}

LazyColumn {
itemsIndexed(appsList, key = { index, item -> item.id }) { index, item ->
var showOptionsMenu by remember(item.id) {
Expand All @@ -141,6 +166,19 @@ fun OpenWithAppListDialog(
.animateItem()
.combinedClickable(
onClick = {
if (rememberChoice.value) {
val defOpeningMethods: DefaultOpeningMethods =
fromJson(globalClass.preferencesManager.defaultOpeningMethods)
?: DefaultOpeningMethods()
globalClass.preferencesManager.defaultOpeningMethods =
DefaultOpeningMethods(
(defOpeningMethods.openingMethods.filter { it.extension != contentHolder.extension } + OpeningMethod(
extension = contentHolder.extension,
packageName = item.packageName,
className = item.name
))
).toJson()
}
contentHolder.openFileWithPackage(
context,
item.packageName,
Expand Down Expand Up @@ -208,4 +246,4 @@ fun OpenWithAppListDialog(
}
}
}
}
}