Make setting ck take extrinsics payable

[gztensor]

Motivation

increase_take and decrease_take were marked as Pays::No, which means these state-mutating delegate take changes did not pay normal transaction fees. These calls should be payable like other user-submitted staking operations.

What Changed

• Changed decrease_take dispatch metadata from Pays::No to Pays::Yes.
• Changed increase_take dispatch metadata from Pays::No to Pays::Yes.
• Added unit coverage asserting both calls remain DispatchClass::Normal and now report Pays::Yes.
• Bumped runtime spec_version from 417 to 418.

Behavioral Impact

Delegate take increase/decrease transactions now participate in normal fee payment. The existing origin checks, take bounds, ownership checks, rate limiting, and underlying staking logic are otherwise unchanged.

Migration / Spec Version

No storage migration is required. This is a runtime-affecting metadata change and includes the required spec_version bump.

Testing

• Added test_delegate_take_dispatch_info_pays_fee for the affected dispatch metadata.
• Author checklist indicates ./scripts/fix_rust.sh and unit tests were run locally.

[github-actions]

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

[github-actions]

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

BASELINE scrutiny: established contributor with repo write permission, substantial prior subtensor activity, no Gittensor allowlist match found; branch feat/ck-take-settings-pays-yes -> devnet-ready.

Static-only review found no .github/ prompt/workflow changes, dependency changes, lockfile changes, build-script changes, or suspicious generated-JS execution hooks. The security-relevant runtime diff is limited to changing decrease_take and increase_take dispatch fee metadata from Pays::No to Pays::Yes, preserving normal dispatch class, carrying a spec_version bump, and retaining the previously reviewed swap_hotkey DB-read accounting fix.

Findings

No findings.

Prior-comment reconciliation

• 97158285: addressed — The current swap_hotkey hunk still accrues reads(3) when new_hotkey exists and reads(1) when it does not, so the earlier DB-read accounting concern remains fixed.

Conclusion

No malicious pattern or security vulnerability was found in the current diff. The prior weight-accounting concern remains addressed.

---

🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor UNKNOWN by allowlists; author has repo write permission and substantial recent subtensor contribution history, so calibrated as established.

Description discrepancies: the PR body is substantive but stale. It says spec_version moved 417 -> 418, while the current diff moves 424 -> 426; it also omits the included do_swap_hotkey ownership pre-check / weight-accounting adjustment and the generated contract-tests/.papi/descriptors/dist bundle.

Overlapping PRs share broad runtime/test/generated files, but I did not identify a duplicate candidate for this exact delegate-take fee metadata change. No auto-fixes were applied, and I did not run tests because the reviewed behavior is covered statically by the dispatch metadata assertions and no finding required runtime confirmation.

Findings

No findings.

Conclusion

Approving: the intended Pays::Yes metadata change is direct, covered by unit assertions, and includes a runtime spec_version bump. The PR body should still be refreshed before merge so reviewers have an accurate change summary.

[github-actions]

🔄 AI review updated — Skeptic: VULNERABLE

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👎

[github-actions]

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

[github-actions]

🔄 AI review updated — Skeptic: VULNERABLE

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👎

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍