add finalize after contract deploy

[open-junius]

Description

Based on failed test sometimes in CI, improve the ts-tests for evm.

Related Issue(s)

• Closes #[issue number]

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have run ./scripts/fix_rust.sh to ensure my code is formatted and linted correctly
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

[github-actions]

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

BASELINE scrutiny: open-junius has write permission, an established account, substantial prior subtensor PR history, and no Gittensor allowlist match; branch avoid-nonce-reuse-error -> devnet-ready.

Reviewed the prefetched metadata, prior Skeptic sticky, contributor signals, and full diff. The PR changes only ts-tests/suites/zombienet_evm/01-contract-deploy-call.test.ts, adding two waitForFinalizedBlocks(api, 1) calls after contract deployment assertions. It does not touch runtime/pallet code, dependencies, CI/workflows, .github/ai-review/*, or .github/copilot-instructions.md. No prior Skeptic findings were present.

Findings

No findings.

Conclusion

No malicious behavior or security vulnerability is evident from this test-only diff. The change is small, matches the stated CI flake mitigation, and has no on-chain or supply-chain security surface.

---

🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Established write-access contributor; not in trusted Gittensor allowlists, but LIKELY by substantial recent subtensor PR history.

The Auditor proposed a replacement PR description, but the current body is non-trivial; not overwriting. Maintainers: ask the Auditor to regenerate if you want it.

Static review only. The change is limited to ts-tests/suites/zombienet_evm/01-contract-deploy-call.test.ts, adding finality waits after the first two EVM contract deployment checks to reduce nonce/finality races between sequential tests. No runtime or pallet code changed, so no spec_version bump is required. No duplicate overlapping PRs were present in the prefetched context.

Findings

No findings.

Conclusion

Approving: the added waits are consistent with existing test-suite synchronization patterns and do not alter chain/runtime behavior. I found no blocking domain issues.

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍