Add Env File Handling to Makefile Generation#5
Open
pokatomnik wants to merge 1 commit into
Open
Conversation
RaphSku
reviewed
May 10, 2026
Owner
RaphSku
left a comment
RaphSku
left a comment
There was a problem hiding this comment.
Thank you a lot for the contribution, a very cool addition.
If you could address the comments and also provide unit tests for the changes, that would be great. I would merge it afterwards :)
| } | ||
|
|
||
| // -- Env files | ||
| cm.logger.Info("Inserting env file includes", zap.Strings("func", cm.Config.EnvFiles)) |
Owner
There was a problem hiding this comment.
Suggested change
| cm.logger.Info("Inserting env file includes", zap.Strings("func", cm.Config.EnvFiles)) | |
| cm.logger.Info("Inserting env file includes", zap.Strings("func", "applyConfig")) |
| } | ||
|
|
||
| type Config struct { | ||
| EnvFiles []string `yaml:"env"` |
Owner
There was a problem hiding this comment.
Suggested change
| EnvFiles []string `yaml:"env"` | |
| EnvFiles []string `yaml:"envFiles"` |
| An example configuration file might look like this: | ||
| ```yaml | ||
| --- | ||
| env: |
Owner
There was a problem hiding this comment.
| ``` | ||
|
|
||
| ### Env files | ||
| List all env files that should be used inside the Makefile |
Owner
There was a problem hiding this comment.
Would be cool to improve the description by describing what this field does or what function it has in a Makefile.
| var content SuggarString | ||
|
|
||
| for _, envFile := range envFiles { | ||
| content.appendString("-include").appendString(" ").appendString(envFile).lineBreak() |
Owner
There was a problem hiding this comment.
Would be cool, if the user could decide whether the include should be optional or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
I've added including env files listed in user's configuration.