feat(Android): Add action buttons for notifications#86
feat(Android): Add action buttons for notifications#86klaakso wants to merge 1 commit intoRapsssito:masterfrom
Conversation
|
@klaakso, thanks for the PR, the code looks good, but I will have to take a closer look. However, you should remove the modifications in the files As soon as you change those files, I will test your code manually and approve your PR if everything works as expected. |
|
Alright. Removed the generated files and added a null check... 😁 |
| final ReadableArray acts = options.getArray("actions"); | ||
| Bundle actions = new Bundle(); | ||
| if(acts != null) { |
There was a problem hiding this comment.
This does not seem to work, if I start the background task without an actions key in the options, the whole background task throws an Error.
There was a problem hiding this comment.
LOG Trying to start background service
LOG Error [Error: null]
Here is an example of the log
|
hello, will this feature be released? Thanks |
4 participants
Fixes #60
Here goes!
Let me know what you think. It's been a while since I've touched Java but feel free to scrutinize! 😁