fix: Fix creation of variables in the main workspace when opening flyout#2686
Merged
gonfunko merged 1 commit intoRaspberryPiFoundation:mainfrom Apr 17, 2026
Conversation
Contributor
|
Thanks for reporting and fixing this, we really appreciate it! |
gonfunko
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #2685
Proposed Changes
Replaced
createBackingVariablemanual get/set calls for variables with Blockly's helper functiongetOrCreateVariablePackage. It handles resolution of variable map correctly (using potentialVariableMap when in flyouts)Reason for Changes
Blockly flyouts have
VariableMappointing to target workspace'sVariableMap. Flyouts store their ownVariableMapinside potentialVariableMap. MethodcreateBackingVariableis makingcreateVariablecalls which creates variables directly on the main workspaceTest Coverage
N/A
Documentation
N/A
Additional Information
N/A