Implement back-end features for "Remove a Classroom" #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the 'deleted' column on the SchoolClass record and DB migration, as well as two scopes called `active` and `deleted` to simplify retrieval of active and deleted classes respectively.
This commit changes the access rules in CanCanCan to prevent any user (student, teacher or owner) from accessing deleted classes.
This means the #index operation only returns classes within the `active` scope, excluding deleted classes.
Instead of calling `destroy!` on SchoolClass, we now call `mark_as_deleted!` instead.
This commit adds broader tests for the behaviour of marked-as-deleted classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #645