codex security#45
Draft
kangkangzi2025 wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the three Codex Security findings from scan
6e230229-de17-433b-84ab-5b27e025bc9a:Root cause
Several persistence helpers trusted string identifiers as path components, local resource ingest trusted caller-selected file/URL sources, and memory recall promoted lower-trust snippets into
role=systemmessages.Validation
uv run pytest tests/backends/persistence/test_registry_gc.py tests/memory/persistence/test_persistence.py tests/session/persistence/test_loader_gc.py tests/memory/local_backend/test_local_memory_commit.py tests/memory/local_backend/test_local_memory_resource.py tests/flow/test_memory_inject.py tests/flow/test_agent_forward_memory.py-> 88 passed, 2 skippeduv run pytest tests/memory/local_backend tests/flow tests/session/persistence tests/backends/persistence tests/memory/persistence-> 203 passed, 6 skippeduv run pytest -m "not opensandbox and not openviking and not live_llm and not integration and not bench"-> 789 passed, 8 skipped, 72 deselected, 1 existing warninguv run ruff check src/rath tests-> passed