Skip to content

feat: add collapsible plugin cards in native apps#74

Merged
aledefra merged 3 commits intodevelopfrom
codex/native-plugin-collapse-arrow
Mar 11, 2026
Merged

feat: add collapsible plugin cards in native apps#74
aledefra merged 3 commits intodevelopfrom
codex/native-plugin-collapse-arrow

Conversation

@aledefra
Copy link
Collaborator

Summary\n- add an expander arrow next to each plugin badge in the Native Apps Plugins step\n- allow each plugin card to toggle between expanded and collapsed states\n- keep plugin content expanded by default and preserve existing remove behavior\n\n## Verification\n- npm run lint -- src/components/create-job/plugins/PluginsSection.tsx

Copilot AI review requested due to automatic review settings March 11, 2026 10:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds per-plugin expand/collapse behavior to the Native Apps “Plugins” step by introducing an expander control in each plugin card header, while keeping cards expanded by default.

Changes:

  • Added Expander control next to each plugin badge in the plugin card header.
  • Implemented per-plugin expanded/collapsed state and conditional rendering of plugin input sections.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings March 11, 2026 10:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...previous,
[plugin.id]: !(previous[plugin.id] ?? true),
}))
}
Copy link

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new expand/collapse control is rendered via Expander, which currently uses a clickable <div> (no keyboard interaction, no role="button", no aria-expanded/label). Since this PR introduces the expander in the job creation flow, please make the control accessible (prefer a <button type="button"> in Expander with aria-expanded and an aria-label, or add equivalent keyboard/ARIA support).

Suggested change
}
}
aria-label={
isExpanded
? 'Collapse plugin details'
: 'Expand plugin details'
}
aria-expanded={isExpanded}
aria-controls={`plugin-card-${plugin.id}`}

Copilot uses AI. Check for mistakes.
@aledefra aledefra merged commit 5818625 into develop Mar 11, 2026
7 checks passed
@aledefra aledefra deleted the codex/native-plugin-collapse-arrow branch March 11, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants