fix(fullscreen): kill the Windows black bar and smooth the F11 toggle#76
Merged
Conversation
The first cut of F11 fullscreen had three problems on Windows with our frameless (decorations:false) window: - Entering fullscreen while maximized left a black bar where the taskbar was / overflowed the right edge (a known tao bug). Now we unmaximize first and restore the maximized state on exit. - F11 wouldn't exit fullscreen because isFullscreen() returns unreliable values for frameless windows. We now track the state ourselves. - The square title-bar button (and title-bar double-click) toggled maximize underneath an active fullscreen, producing the broken state. While fullscreen they now exit fullscreen, and the button shows an "exit fullscreen" icon. Also masks the mid-transition reflow: the unmaximize->fullscreen step resizes the window twice, so the content visibly snapped. An opaque cover drops in instantly, the OS resizes behind it, then it fades out — the change reads as a smooth dip instead of a jump. Adds the core:window:allow-unmaximize capability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fix to #75 (F11 fullscreen), addressing Windows feedback.
Problems fixed
On our frameless (
decorations:false) window on Windows:isFullscreen()returns unreliable values for frameless windows, so we now track the state ourselves.Polish
The unmaximize→fullscreen step resizes the window twice, so the content visibly snapped. An opaque cover drops in instantly, the window resizes behind it, then fades out — a smooth dip instead of a jump.
Adds the
core:window:allow-unmaximizecapability.Testing
tsc --noEmitcleantauri devon Windows: all three cases clean, transition smooth.