Store favourite comments per-activity#457
Draft
Terrance wants to merge 8 commits intoRazeeman:devfrom
Draft
Conversation
Owner
|
Hello! Thank you very much for the help. About the UX. One way that comes to mind is to mirror how tags currently working. So clicking on favourite icon will add favourite comment only for the selected activity. Long clicking on added favourite comment will open an edit screen with ability to select another activity or select no activity which will mean that comment can be used for all activities. Also it is probably better to allow assigning one fav comment to several activities. To allow this it is possible to add a separate DBO similar to RecordTypeToTagDBO, that will store a relation between activity typeId and fav comment id. Instead of adding only one typeId field to FavouriteCommentDBO. Future ideas to expand:
Hope this makes sense. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends favourite comments to be optionally associated with a single activity. The favourites hints combine "global" comments from all activities with "local" ones belonging to the currently-selected activity.
Still to do:
UX: Currently tapping the star button adds a local favourite, while long-pressing it creates a global one. The star turns red and the hint appears when either exist, so currently there's no way to tell the two cases apart, nor is it apparent that two modes of favouriting exist. Open to suggestions on how to present this.
Tests: Not yet investigated, besides the minimum amount of updates of test utils needed to fix compilation.
Fixes #453.