-
Notifications
You must be signed in to change notification settings - Fork 10
Stress metrics extension #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
abdelrahman-ayad
wants to merge
66
commits into
main
Choose a base branch
from
aa/metrics_extension
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
66 commits
Select commit
Hold shift + click to select a range
5f40e60
minimal example on how to call CVAR in run_pras.jl
abdelrahman-ayad 4a867e6
minor fix to `get_params`
abdelrahman-ayad b11b588
generalize eue methods to stress metrics
abdelrahman-ayad 42f38c5
update stress metrics in cases.csv
abdelrahman-ayad 62e0be2
add validation checks for switches
abdelrahman-ayad 71dd317
Merge branch 'main' into aa/multi_metrics
abdelrahman-ayad 926d6d8
fix a bug when searching for the switch
abdelrahman-ayad fc03be8
generalize check for stressThresholdMetrics
abdelrahman-ayad d67e237
minor comment edit
abdelrahman-ayad 064828b
comment stress_periods debugging code
abdelrahman-ayad c2c9cc5
refactor stress_periods; get_shoulder periods uses capacity only (not…
abdelrahman-ayad 52bdfdd
remove debugging csv output
abdelrahman-ayad b632dad
minor fix
abdelrahman-ayad 558e384
warning and error messages for `stressThresholdMetricSwitches`
abdelrahman-ayad 37703fe
comment debugging lines
abdelrahman-ayad f246fd2
Merge branch 'main' into aa/multi_metrics
abdelrahman-ayad 50fae67
update get_pras_stress_metric call
abdelrahman-ayad 10f7ba5
replace ReEDS_Augur by handoff dir name
abdelrahman-ayad b5c0384
minor fix
abdelrahman-ayad a0c7959
minor fixes
abdelrahman-ayad 767547e
keep EUE as default metric in cases.csv
abdelrahman-ayad 435dcdb
update switches logic
abdelrahman-ayad 4e054d6
remove error if switch is not specified
abdelrahman-ayad 0280c95
remove CVAR info
abdelrahman-ayad 5ea585a
untrack cases_multi and srun_template
abdelrahman-ayad 2e74fae
Merge branch 'main' into aa/multi_metrics
abdelrahman-ayad 40fffa5
update dir from augur_data to PRAS
abdelrahman-ayad 4070ea7
`reeds_data` instead of `PRAS` folder
abdelrahman-ayad 987bc0e
USE PRAS NEUE calculations
abdelrahman-ayad aab0a08
fix a bug in get_pras_stress_metric not getting NEUE values
abdelrahman-ayad cc52dd8
remove debug statements
abdelrahman-ayad 1aa6e04
minor PRAS print change
abdelrahman-ayad 5e1271d
update NEUE switch name
abdelrahman-ayad 041985b
change default `GSw_PRM_StressThresholdMetrics` to NEUE
abdelrahman-ayad e248912
uppercase NEUE
abdelrahman-ayad fc1e33f
update _stress_metric extraction
abdelrahman-ayad 977536e
update NEUE keywords
abdelrahman-ayad ae1b613
always include NEUE reporting
abdelrahman-ayad a99df3a
Merge branch 'main' into aa/multi_metrics
abdelrahman-ayad 79db702
revert default metric to EUE to match main
abdelrahman-ayad ce7c0d5
Merge branch 'main' into aa/multi_metrics
abdelrahman-ayad 7babd28
Revert "uppercase NEUE"
abdelrahman-ayad 02d9679
update switches and description
abdelrahman-ayad a4e643f
addressing PB's comments.
abdelrahman-ayad 0a9b73f
address review comments
abdelrahman-ayad 035c4a8
Merge branch 'main' into aa/multi_metrics
abdelrahman-ayad dc9694c
addressing comments; changing LOLE to LOLH
abdelrahman-ayad 42bbf6c
remove LOLE from loop
abdelrahman-ayad 41e2ffd
Merge branch 'main' into aa/multi_metrics
abdelrahman-ayad 690d4d4
fix switches parsing
abdelrahman-ayad 84c33b1
revert NEUE to neue
abdelrahman-ayad cbca500
minor formatting
abdelrahman-ayad 9e885c4
Merge branch 'aa/multi_metrics' of github.com:ReEDS-Model/ReEDS into …
abdelrahman-ayad bd0d0ad
revert shoulder_periods changes: use EUE for LOLH
abdelrahman-ayad a42b6a0
remove EUE from switches list
abdelrahman-ayad 98c1240
revert NEUE to neue
abdelrahman-ayad e88a1c8
Merge branch 'main' into aa/multi_metrics
abdelrahman-ayad 0a0d986
initial implementation of outage duration
abdelrahman-ayad 360cda4
add `OutageDuration` and `OutageMagnitude` metrics
abdelrahman-ayad 704a0b1
add metrics to `cases.csv` and extend validation
abdelrahman-ayad 047caf2
extend stress_metric_units dict
abdelrahman-ayad 3afcdac
minor change
abdelrahman-ayad 3c74b66
add LOLE
abdelrahman-ayad a0e0c0c
add LOLE
abdelrahman-ayad 8e539ab
restore EUE for shoulder_periods calculation
abdelrahman-ayad ef566e2
fix prm updates for non-NEUE
abdelrahman-ayad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -263,14 +263,20 @@ GSw_PRM_NetImportLimit,Turn on (1) or off (0) the eq_firm_transfer_limit constra | |||||
| GSw_PRM_NetImportLimitScen,/-delimited list of {year}_{max percent import OR 'hist' for historical percent OR 'histmax' for max historical percent across all regions} values to use in eq_firm_transfer_limit,N/A,2031_hist/2050_100, | ||||||
| GSw_PRM_scenario,"column of inputs/reserves/prm_annual.csv from which to draw the PRM (""nerc"" means the annual values from the 2024 NERC LTRA; ""static"" means the 2024 values from the same source); or a float (like 0.12) which gets applied as a fraction to all regions in all years (0.12 means 12%)",(static|nerc|ramp2025_20by50|^\d*\.?\d+$),0.12, | ||||||
| GSw_PRM_StressIncrement,How many stress periods to add per iteration,int,2, | ||||||
| GSw_PRM_StressIterateMax,Max number of times to iterate on a given solve year to achieve GSw_PRM_StressThreshold when using stress periods (0 means don't iterate; 1 means 1 extra ReEDS run; etc),int,5, | ||||||
| GSw_PRM_StressIterateMax,"Max number of times to iterate on a given solve year to achieve adequacy stress levels (e.g., GSw_PRM_StressThresholdNEUE) when using stress periods (0 means don't iterate; 1 means 1 extra ReEDS run; etc)",int,5, | ||||||
| GSw_PRM_StressLoadAggMethod,How to aggregate load for stress periods within the chunks specified by GSw_HourlyChunkLengthStress (only used if GSw_HourlyChunkAggMethod=mean; otherwise GSw_HourlyChunkAggMethod is used),mean; max,max, | ||||||
| GSw_PRM_StressModel,Model used to identify stress periods: pras or a string starting with 'user' which specifies a file at inputs/temporal/stressperiods_{GSw_PRM_StressModel}.csv,N/A,pras, | ||||||
| GSw_PRM_StressOutages,Whether to apply the availability factor (forced + scheduled outages) during stress periods,0; 1,1, | ||||||
| GSw_PRM_StressSeedLoadLevel,Region hierarchy level at which to include peak coincident load days as seeded stress periods (or False to ignore peaks),false; False; FALSE; r; nercr; transreg; transgrp; cendiv; st; interconnect; country; usda_region; ccreg,transgrp, | ||||||
| GSw_PRM_StressSeedMinRElevel,Region hierarchy level at which to include minimum wind and solar capacity factor days as seeded stress periods (or False to ignore min-wind/solar CF days),false; False; FALSE; r; nercr; transreg; transgrp; cendiv; st; interconnect; country; usda_region; ccreg,interconnect, | ||||||
| GSw_PRM_StressStorageCutoff,"How to select ""shoulder"" stress periods giving storage time to recharge before/after high-unserved-energy periods. Two-part switch separated by _. The first argument is ""EUE"" or ""capacity"" or ""absolute"". If ""EUE"" the second argument specifies a PRAS storage headspace / EUE threshold [fraction]; if ""cap"" it specifies a headspace / storage capacity threshold [fraction]; if ""abs"" it specifies absolute number of periods before/after [integer]. Turned off if set to ""off"".",N/A,EUE_0.1, | ||||||
| GSw_PRM_StressThreshold,/-delimited list of annual NEUE level [ppm] above which to re-solve the latest model year with new stress periods; formulated as HierarchyLevel_NEUEppm_StressMetric_PeriodAggMethod where HierarchyLevel is a column in hierarchy.csv; NEUEppm is normalized expected unserved energy in parts per million; StressMetric is EUE or NEUE (only used in period selection); PeriodAggMethod is 'sum' or 'max' over the hours in each period (only used in period selection) (see README.md for detailed notes),N/A,transgrp_1_EUE_sum, | ||||||
| GSw_PRM_StressThresholdMetrics,"/-delimited list of metrics for identifying stress periods (supported options are: NEUE, LOLH)",N/A,NEUE, | ||||||
| GSw_PRM_StressThresholdLOLH,LOLH threshold [hours/year] above which to re-solve the latest model year with new stress periods; formulated as HierarchyLevel_LOLH_PeriodAggMethod where HierarchyLevel is a column in hierarchy.csv; LOLH is loss of load event-hours per year [event-h/year]; PeriodAggMethod is 'sum' or 'max' over the hours in each period (only used in period selection) (see README.md for detailed notes),N/A,transgrp_2.4_sum, | ||||||
| GSw_PRM_StressThresholdLOLE,LOLE threshold [event-days/year] above which to re-solve the latest model year with new stress periods; formulated as HierarchyLevel_LOLEdays_PeriodAggMethod where HierarchyLevel is a column in hierarchy.csv; LOLEdays is loss of load event-days per year (a day is counted if at least one hour has a shortfall) [event-day/year]; PeriodAggMethod is 'sum' or 'max' over the hours in each period (only used in period selection) (see README.md for detailed notes),N/A,transgrp_0.1_max, | ||||||
| GSw_PRM_StressThresholdNEUE,Annual NEUE level [ppm] threshold above which to re-solve the latest model year with new stress periods; formulated as HierarchyLevel_NEUEppm_PeriodAggMethod where HierarchyLevel is a column in hierarchy.csv; NEUEppm is normalized expected unserved energy in parts per million [ppm]; PeriodAggMethod is 'sum' or 'max' over the hours in each period (only used in period selection) (see README.md for detailed notes),N/A,transgrp_1_sum, | ||||||
| GSw_PRM_StressThresholdOutageDuration,Outage duration; formulated as HierarchyLevel_OutageDurationHours_PeriodAggMethod where HierarchyLevel is a column in hierarchy.csv; OutageDurationHours is the max outage duration in hours; PeriodAggMethod is 'max' over the hours in each period (only used in period selection) (see README.md for detailed notes),N/A,transgrp_10000_max, | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| GSw_PRM_StressThresholdOutageMagnitude,Outage magnitude; formulated as HierarchyLevel_OutageMagnitudeMW_PeriodAggMethod where HierarchyLevel is a column in hierarchy.csv; OutageMagnitudeMW is the max outage magnitude in MW; PeriodAggMethod 'max' over the hours in each period (only used in period selection) (see README.md for detailed notes),N/A,transgrp_0.1_max, | ||||||
| GSw_PRM_StressThresholdNormalizedOutageMagnitude,Normalized outage magnitude; formulated as HierarchyLevel_NormalizedOutageMagnitude_PeriodAggMethod where HierarchyLevel is a column in hierarchy.csv; NormalizedOutageMagnitude is the max outage normalized magnitude (ratio of the maxmimum load) ; PeriodAggMethod is 'max' over the hours in each period (only used in period selection) (see README.md for detailed notes),N/A,transgrp_10_max, | ||||||
|
Comment on lines
+278
to
+279
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||||||
| GSw_PRM_UpdateFraction,Fraction to add to the PRM if a region fails RA threshold (only used if GSw_PRM_UpdateMethod = 1),float,0.02, | ||||||
| GSw_PRM_UpdateMethod,Option to update PRM: (0) no update; (1) static update set by GSw_PRM_UpdateFraction; (2) dynamic update informed by PRAS; (3) dynamic update but only after all new stress periods have been added,0; 1; 2; 3,0, | ||||||
| GSw_PRMTRADE_level,hierarchy level within which to allow PRM trading,r; nercr; transreg; transgrp; cendiv; st; interconnect; country; usda_region,country, | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've seen different definitions used in different sources, but at least in some places, "LOLE" is taken to mean "events" and LOLD as "event-days". So if the units used here are "event-days", then it might be clearer to label it as LOLD.
Here's the figure I'm thinking of, from https://doi.org/10.1109/PMAPS53380.2022.9810615: